From: Florian Westphal <fw@strlen•de>
To: David Miller <davem@davemloft•net>
Cc: fw@strlen•de, netdev@vger•kernel.org, a@unstable•cc,
sw@simonwunderlich•de, mareklindner@neomailbox•ch,
sven@narfation•org
Subject: Re: [PATCH next] sched: remove NET_XMIT_POLICED
Date: Sat, 11 Jun 2016 11:06:05 +0200 [thread overview]
Message-ID: <20160611090605.GA3669@breakpoint.cc> (raw)
In-Reply-To: <20160611.000047.2179423929953796335.davem@davemloft.net>
David Miller <davem@davemloft•net> wrote:
> I have to revert this, the sch_atm.c change is wrong.
>
> NET_XMIT_POLICED is the default value of 'ret' which can be used
> if we branch to 'drop'. So now GCC says that 'ret' might be used
> uninitialized.
Hmpf, seems I need to update gcc :-|
> So it is actually used, and reported by sch_atm when TC_ACT_SHOT
> classifications occur.
I'll resubmit a v2 changing initializer to NET_XMIT_DROP.
prev parent reply other threads:[~2016-06-11 9:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 12:21 [PATCH next] sched: remove NET_XMIT_POLICED Florian Westphal
2016-06-10 14:28 ` Eric Dumazet
2016-06-10 16:30 ` Sven Eckelmann
2016-06-11 6:31 ` David Miller
2016-06-11 7:00 ` David Miller
2016-06-11 9:06 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160611090605.GA3669@breakpoint.cc \
--to=fw@strlen$(echo .)de \
--cc=a@unstable$(echo .)cc \
--cc=davem@davemloft$(echo .)net \
--cc=mareklindner@neomailbox$(echo .)ch \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sven@narfation$(echo .)org \
--cc=sw@simonwunderlich$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox