Subject: Re: wl3501_cs: avoid bogus gcc-6 warning

From: Kalle Valo <[email-masked]>
Date: Thu, 16 Jun 2016 15:06:54 +0000 (UTC)

Arnd Bergmann <[email-masked]> wrote:
> gcc-6 on x86 started warning about wl3501_get_encode when building
> with -O2:
> 
> drivers/net/wireless/wl3501_cs.c: In function ‘wl3501_get_encode’:
> drivers/net/wireless/wl3501_cs.c:1769:5: warning: ‘implemented’ may be used uninitialized in this function
> drivers/net/wireless/wl3501_cs.c:1686:19: warning: ‘threshold’ may be used uninitialized in this function
> drivers/net/wireless/wl3501_cs.c:1702:20: warning: ‘threshold’ may be used uninitialized in this function
> drivers/net/wireless/wl3501_cs.c:1719:23: warning: ‘txpow’ may be used uninitialized in this function
> drivers/net/wireless/wl3501_cs.c:1752:20: warning: ‘retry’ may be used uninitialized in this function
> drivers/net/wireless/wl3501_cs.c:1806:25: warning: ‘pwr_state’ may be used uninitialized in this function
> drivers/net/wireless/wl3501_cs.c:1383:24: warning: ‘value’ may be used uninitialized in this function
> 
> I could not figure out what exactly confuses gcc here, but splitting the
> wl3501_get_mib_value function into two helps the compiler to figure out
> that the variables are not actually used uninitialized, and makes it
> slightly clearer to a human reader what the function actually does and
> which parts of it are under the spinlock.
> 
> Signed-off-by: Arnd Bergmann <[email-masked]>

Thanks, 1 patch applied to wireless-drivers-next.git:

2683f7dd9aad wl3501_cs: avoid bogus gcc-6 warning

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/9138643/