Subject: Re: mwifiex: fix link error against sdio

From: Kalle Valo <[email-masked]>
Date: Sat, 18 Jun 2016 13:36:52 +0000 (UTC)

Arnd Bergmann <[email-masked]> wrote:
> Calling sdio_claim_host() from the interface independent part of
> the mwifiex driver is not only a layering violation, but also causes
> a link error if MMC support is disabled, or if CONFIG_MMC=m
> and CONFIG_MWIFIEX=y:
> 
> drivers/net/built-in.o: In function `mwifiex_fw_dpc':
> :(.text+0xff138): undefined reference to `sdio_claim_host'
> :(.text+0xff158): undefined reference to `sdio_release_host'
> 
> The right way to do this is to have the sdio specific code in the
> sdio driver front-end, and we already have a callback pointer that
> we can use for this after exporting the generic fw download
> function from the core driver.
> 
> Signed-off-by: Arnd Bergmann <[email-masked]>
> Fixes: 65c71efe1c59 ("mwifiex: fix racing condition when downloading firmware")

Thanks, 1 patch applied to wireless-drivers-next.git:

2095b1426c9c mwifiex: fix link error against sdio

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/9180095/