Subject: Re: [PATCH v4 01/16] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

From: Johan Hedberg <[email-masked]>
Date: Fri, 24 Jun 2016 10:19:08 +0300

On Thu, Jun 23, 2016, Andy Lutomirski wrote:
> SMP does ECB crypto on stack buffers.  This is complicated and
> fragile, and it will not work if the stack is virtually allocated.
> 
> Switch to the crypto_cipher interface, which is simpler and safer.
> 
> Cc: Marcel Holtmann <[email-masked]>
> Cc: Gustavo Padovan <[email-masked]>
> Cc: Johan Hedberg <[email-masked]>
> Cc: "David S. Miller" <[email-masked]>
> Cc: [email-masked]
> Cc: Herbert Xu <[email-masked]>
> Cc: [email-masked]
> Signed-off-by: Andy Lutomirski <[email-masked]>
> ---
>  net/bluetooth/smp.c | 67 ++++++++++++++++++++++-------------------------------
>  1 file changed, 28 insertions(+), 39 deletions(-)

Acked-and-tested-by: Johan Hedberg <[email-masked]>

Johan