Subject: Re: [PATCH v4 01/29] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

From: Ingo Molnar <[email-masked]>
Date: Mon, 27 Jun 2016 10:54:03 +0200

* Marcel Holtmann <[email-masked]> wrote:

> Hi Andy,
> 
> > SMP does ECB crypto on stack buffers.  This is complicated and
> > fragile, and it will not work if the stack is virtually allocated.
> > 
> > Switch to the crypto_cipher interface, which is simpler and safer.
> > 
> > Cc: Marcel Holtmann <[email-masked]>
> > Cc: Gustavo Padovan <[email-masked]>
> > Cc: Johan Hedberg <[email-masked]>
> > Cc: "David S. Miller" <[email-masked]>
> > Cc: [email-masked]
> > Cc: [email-masked]
> > Acked-by: Herbert Xu <[email-masked]>
> > Acked-and-tested-by: Johan Hedberg <[email-masked]>
> > Signed-off-by: Andy Lutomirski <[email-masked]>
> > ---
> > net/bluetooth/smp.c | 67 ++++++++++++++++++++++-------------------------------
> > 1 file changed, 28 insertions(+), 39 deletions(-)
> 
> patch has been applied to bluetooth-next tree.

Sadly carrying this separately will delay the virtual kernel stacks feature by a 
kernel cycle, because it's a must-have prerequisite.

Thanks,

	Ingo