From: Phil Sutter <phil@nwl•cc>
To: Greg Rose <gvrose8192@gmail•com>
Cc: Stephen Hemminger <shemming@brocade•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [iproute PATCH 1/2] ipaddress: Simplify vf_info parsing
Date: Fri, 1 Jul 2016 19:50:01 +0200 [thread overview]
Message-ID: <20160701175001.GG19370@orbyte.nwl.cc> (raw)
In-Reply-To: <CALgkqUq8uDErRPMxyDx-M5UQB3v5+tHMyxXpAmK381W_z9KXPg@mail.gmail.com>
On Wed, Jun 01, 2016 at 03:36:09PM -0700, Greg Rose wrote:
> On Wed, Jun 1, 2016 at 3:07 PM, Phil Sutter <phil@nwl•cc> wrote:
> > On Wed, Jun 01, 2016 at 03:00:08PM -0700, Greg Rose wrote:
> >> On Wed, Jun 1, 2016 at 1:03 PM, Phil Sutter <phil@nwl•cc> wrote:
> >> > Not sure whether I misinterpret commit 7b8179c780a1a, but it looks
> >> > overly complicated. Instead rely upon parse_rtattr_nested() to assign
> >> > the relevant pointer if requested rtattr fields are present.
> >>
> >> I'm not sure if newer iproute2 utilities are supposed to work on older
> >> kernels but if it is you may want to check this against a 2.6.32
> >> kernel.
> >
> > Yes, it is supposed to. Actually I tried, but the old RHEL6 kernel I
> > used didn't export the VF list at all and then I lost motivation.
> >
> > I didn't check all earlier versions of 7b8179c780a1a, was there a stage
> > when it looked like what I'm changing it to?
>
> I don't think so but your patch looks correct - I mean it looks like
> it should work.
>
> It's been 5 years since I wrote that original patch and my memory
> isn't so great as to why I didn't just do as your patch does but I
> think it had something to do with not all drivers reporting a spoof
> check value. However, your patch should handle that case so I see no
> reason not to accept it. Unfortunately I don't have time or the
> resources at the moment to check it on an older kernel.
So can I count that as your Acked-by? ;)
Looks like Stephen hesitates to accept this patch due to the discussion
it provoked.
Cheers, Phil
next prev parent reply other threads:[~2016-07-01 17:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 20:03 [iproute PATCH 0/2] Minor vf_info review Phil Sutter
2016-06-01 20:03 ` [iproute PATCH 1/2] ipaddress: Simplify vf_info parsing Phil Sutter
2016-06-01 22:00 ` Greg Rose
2016-06-01 22:07 ` Phil Sutter
2016-06-01 22:36 ` Greg Rose
2016-07-01 17:50 ` Phil Sutter [this message]
2016-07-20 20:10 ` Phil Sutter
2016-08-17 21:27 ` Phil Sutter
2016-06-01 20:03 ` [iproute PATCH 2/2] ipaddress: Print IFLA_VF_QUERY_RSS_EN setting Phil Sutter
-- strict thread matches above, loose matches on Subject: below --
2016-11-08 21:29 [iproute PATCH 0/2] Resend: Simplify and enhance vf_info parsing Phil Sutter
2016-11-08 21:29 ` [iproute PATCH 1/2] ipaddress: Simplify " Phil Sutter
2016-11-08 23:05 ` Greg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160701175001.GG19370@orbyte.nwl.cc \
--to=phil@nwl$(echo .)cc \
--cc=gvrose8192@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemming@brocade$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox