From: Andrew Lunn <andrew-g2DYL2Zd6BY@public•gmane.org>
To: Jamie Lentin <jm-Pj/HzkgeCk7QXOPxS62xeg@public•gmane.org>
Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public•gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public•gmane.org>,
Imre Kaloz <kaloz-p3rKhJxN3npAfugRpC6u6w@public•gmane.org>,
Florian Fainelli
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH v0 06/10] arm: orion5x: Add DT-based support for Netgear WNR854T
Date: Sat, 16 Jul 2016 18:34:08 +0200 [thread overview]
Message-ID: <20160716163408.GG1777@lunn.ch> (raw)
In-Reply-To: <1468679348-10522-7-git-send-email-jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
> + chosen {
> + bootargs = "console=ttyS0,115200n8 earlyprintk";
> + linux,stdout-path = &uart0;
> + };
You can put the board rate etc in the stdout-patch. Something like:
stdout-path = "serial0:115200n8";
> + gpio-leds {
> + compatible = "gpio-leds";
> + pinctrl-0 = <&pmx_power_led &pmx_power_led_blink &pmx_wan_led>;
> + pinctrl-names = "default";
> +
> + led@0 {
> + label = "power:green";
Documentation/leds/leds-class.txt says:
LED Device Naming
=================
Is currently of the form:
"devicename:colour:function"
> + dsa@0 {
> + compatible = "marvell,dsa";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + dsa,ethernet = <ðport>;
> + dsa,mii-bus = <&mdio>;
> +
> + switch@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0 0>; /* MDIO address 0, switch 0 in tree */
> +
> + port@0 {
> + reg = <0>;
> + label = "lan3";
> + };
> +
> + port@1 {
> + reg = <1>;
> + label = "lan4";
> + };
> +
> + port@2 {
> + reg = <2>;
> + label = "wan";
> + };
> +
> + port@3 {
> + reg = <3>;
> + label = "cpu";
> + };
> +
> + port@5 {
> + reg = <5>;
> + label = "lan1";
> + };
> +
> + port@7 {
> + reg = <7>;
> + label = "lan2";
> + };
> + };
> + };
> +};
This all looks sensible, if a bit mixed up. Lets discuss the switch
issue in a different thread.
> +&devbus_bootcs {
> + status = "okay";
> +
> + devbus,keep-config;
> +
> + flash@0 {
> + compatible = "cfi-flash";
> + reg = <0 0x800000>;
> + bank-width = <1>;
> + #address-cells = <1>;
> + #size-cells = <1>;
Documentation/devicetree/bindings/mtd/partition.txt says the
partitions should be placed under a partitions node. There are some
conditions when that does not work. So please try it, and if it does
not, ignore my comment...
> +
> + partition@0 {
> + label = "kernel";
> + reg = <0x0 0x100000>;
> + };
> +
> + partition@100000 {
> + label = "rootfs";
> + reg = <0x100000 0x660000>;
> + };
> +
> + partition@760000 {
> + label = "uboot_env";
> + reg = <0x760000 0x20000>;
> + };
> +
> + partition@780000 {
> + label = "uboot";
> + reg = <0x780000 0x80000>;
> + read-only;
> + };
> + };
> +};
> +&pinctrl {
> + pinctrl-0 = <&pmx_pci_gpios &pmx_ge>;
> + pinctrl-names = "default";
> +
> + pmx_power_led: pmx-power-led {
> + marvell,pins = "mpp0";
> + marvell,function = "gpio";
> + };
> +
> + pmx_reset_switch: pmx-reset-switch {
> + marvell,pins = "mpp1";
> + marvell,function = "gpio";
> + };
Ah, this is missing from your DSA node. You can then add:
reset-gpios = <&gpio0 1 GPIO_ACTIVE_LOW>;
inside the switch@0 node.
> + pmx_ge: pmx-ge {
> + marvell,pins = "mpp9", "mpp12", "mpp13", "mpp14", "mpp15",
> + "mpp16", "mpp17", "mpp18", "mpp19";
> + marvell,function = "ge";
> + };
> +};
This can go into the .dtsi file your previous patch added.
> +
> +&uart0 {
> + /* Pin 1: Tx, Pin 7: Rx, Pin 8: Gnd */
> + status = "okay";
Nice to see the comment.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-07-16 16:34 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 14:28 [PATCH v0 00/10] Convert Netgear WNR854T to devicetree Jamie Lentin
2016-07-16 14:28 ` [PATCH v0 01/10] arm: orion5x: Add required properties for orion-wdt to DT node Jamie Lentin
2016-07-16 16:03 ` Andrew Lunn
2016-07-16 14:29 ` [PATCH v0 02/10] arm: orion5x: Add documentation for SoC and board bindings Jamie Lentin
[not found] ` <1468679348-10522-3-git-send-email-jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
2016-07-16 16:05 ` Andrew Lunn
2016-07-17 20:35 ` Rob Herring
2016-07-16 14:29 ` [PATCH v0 03/10] arm: orion5x: Add clk support for mv88f5181 Jamie Lentin
[not found] ` <1468679348-10522-4-git-send-email-jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
2016-07-16 16:10 ` Andrew Lunn
2016-07-16 17:34 ` Sergei Shtylyov
2016-07-17 20:36 ` Rob Herring
2016-07-16 14:29 ` [PATCH v0 04/10] arm: orion5x: Generalise mv88f5181l pinctrl support for 88f5181 Jamie Lentin
2016-07-16 16:15 ` Andrew Lunn
[not found] ` <1468679348-10522-5-git-send-email-jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
2016-07-17 20:40 ` Rob Herring
2016-07-16 14:29 ` [PATCH v0 05/10] arm: orion5x: Add DT include for mv88f5181 Jamie Lentin
[not found] ` <1468679348-10522-6-git-send-email-jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
2016-07-16 16:17 ` Andrew Lunn
2016-07-17 20:41 ` Rob Herring
2016-07-16 14:29 ` [PATCH v0 06/10] arm: orion5x: Add DT-based support for Netgear WNR854T Jamie Lentin
[not found] ` <1468679348-10522-7-git-send-email-jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
2016-07-16 16:34 ` Andrew Lunn [this message]
2016-07-16 16:39 ` Andrew Lunn
2016-07-16 19:10 ` Arnd Bergmann
2016-07-17 9:39 ` Jamie Lentin
2016-07-17 20:41 ` Arnd Bergmann
2016-07-18 9:44 ` Thomas Petazzoni
2016-07-18 10:06 ` Arnd Bergmann
2016-07-19 9:40 ` Jamie Lentin
2016-07-19 9:46 ` Arnd Bergmann
2016-07-17 20:51 ` Rob Herring
2016-07-19 9:46 ` Jamie Lentin
2016-07-16 14:29 ` [PATCH v0 07/10] arm: orion5x: Remove old non-DT-based WNR854T support Jamie Lentin
2016-07-16 16:36 ` Andrew Lunn
2016-07-16 14:29 ` [PATCH v0 08/10] net: phy: Try looking for a phy-handle property to find the OF node Jamie Lentin
2016-07-16 16:44 ` Andrew Lunn
2016-07-16 14:29 ` [PATCH v0 09/10] net: phy: Re-attempt custom DT configuration after configuration Jamie Lentin
[not found] ` <1468679348-10522-10-git-send-email-jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
2016-07-16 16:44 ` Andrew Lunn
2016-07-16 14:29 ` [PATCH v0 10/10] arm: orion5x: Configure Netgear WNR854T network port LEDs Jamie Lentin
2016-07-16 20:53 ` [PATCH v0 00/10] Convert Netgear WNR854T to devicetree Andrew Lunn
2016-07-17 12:52 ` Jamie Lentin
2016-07-17 15:33 ` Andrew Lunn
2016-07-19 9:33 ` Jamie Lentin
2016-07-19 14:01 ` Andrew Lunn
2016-07-19 14:16 ` Andrew Lunn
2016-07-19 15:04 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160716163408.GG1777@lunn.ch \
--to=andrew-g2dyl2zd6by@public$(echo .)gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public$(echo .)gmane.org \
--cc=jason-NLaQJdtUoK4Be96aLqz0jA@public$(echo .)gmane.org \
--cc=jm-Pj/HzkgeCk7QXOPxS62xeg@public$(echo .)gmane.org \
--cc=kaloz-p3rKhJxN3npAfugRpC6u6w@public$(echo .)gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox