From: Andrew Lunn <andrew@lunn•ch>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
Cc: David Miller <davem@davemloft•net>,
Jamie Lentin <jm@lentin•co.uk>,
Florian Fainelli <f.fainelli@gmail•com>,
Vivien Didelot <vivien.didelot@savoirfairelinux•com>,
netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH 3/4] dsa: mv88e6xxx: Delete ppu timer when removing module
Date: Tue, 23 Aug 2016 16:10:16 +0200 [thread overview]
Message-ID: <20160823141016.GG20029@lunn.ch> (raw)
In-Reply-To: <d20478f0-c11a-dfb2-26d0-a65db4119124@cogentembedded.com>
> >+static void mv88e6xxx_phy_destroy(struct mv88e6xxx_chip *chip)
> >+{
> >+ if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_PPU)) {
> >+ mv88e6xxx_ppu_state_destroy(chip);
> >+ }
>
> {} not needed here. See Documentation/CodingStyle, chapter 3.
Agreed, I will send a follow up patch, since the patchset has been
accepted.
Thanks
Andrew
next prev parent reply other threads:[~2016-08-23 16:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 14:01 [PATCH 0/4] Fix MV88E6131 tagging Andrew Lunn
2016-08-22 14:01 ` [PATCH 1/4] net: dsa: Allow the DSA driver to indicate the tag protocol Andrew Lunn
2016-08-22 14:32 ` Vivien Didelot
2016-08-22 14:01 ` [PATCH 2/4] net: dsa: mv88e6xxx: Fix support for DSA tagging for older switches Andrew Lunn
2016-08-22 14:41 ` Vivien Didelot
2016-08-22 14:01 ` [PATCH 3/4] dsa: mv88e6xxx: Delete ppu timer when removing module Andrew Lunn
2016-08-22 14:51 ` Vivien Didelot
2016-08-22 15:07 ` Andrew Lunn
2016-08-22 15:39 ` Vivien Didelot
2016-08-23 13:37 ` Sergei Shtylyov
2016-08-23 14:10 ` Andrew Lunn [this message]
2016-08-22 14:01 ` [PATCH 4/4] net: mv88e6xxx: Enable PORT_CONTROL_FORWARD_UNKNOWN for DSA-tagged CPU ports Andrew Lunn
2016-08-22 15:16 ` Vivien Didelot
2016-08-22 14:36 ` [PATCH 0/4] Fix MV88E6131 tagging Jamie Lentin
2016-08-23 4:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823141016.GG20029@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jm@lentin$(echo .)co.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox