Subject: Re: [PATCH 1/4] net: phy: Add Edge-rate driver for Microsemi PHYs.

From: Andrew Lunn <[email-masked]>
Date: Wed, 24 Aug 2016 14:59:34 +0200

On Wed, Aug 24, 2016 at 12:20:03PM +0000, Raju Lakkaraju wrote:
> From: Nagaraju Lakkaraju <[email-masked]>
> 
> Edge rate control support will be added for VSC 85xx Microsemi PHYs.

> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 2d24b28..8ec4c09 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -586,6 +586,8 @@ struct phy_driver {
>         void (*get_strings)(struct phy_device *dev, u8 *data);
>         void (*get_stats)(struct phy_device *dev,
>                           struct ethtool_stats *stats, u64 *data);
> +       int (*phy_features_set)(struct phy_device *dev);
> +       int (*phy_features_get)(struct phy_device *dev);
>  };

Now we need the missing cover note what should be in 0/4.  What is the
big picture? How are these two functions supposed to be used? Is there
going to be a user space API via netlink? Should the MAC driver
somehow call these functions? Are you going to extend the phylib with
code to call these?

Those are all general questions for these two functions.

Now specifically for edge control, why did you decide not to use
device tree? Both the micrel and renesas phy driver uses device tree
for skew control. You need to explain why you need to do something
different to other drivers.

	  Thanks
		Andrew