Subject: Re: [PATCH net-next V3 2/4] net/dst: Utility functions to build dst_metadata without supplying an skb

From: Shmulik Ladkani <[email-masked]>
Date: Thu, 25 Aug 2016 19:40:50 +0300

Hi,

On Thu, 25 Aug 2016 19:13:45 +0300 Hadar Hen Zion <[email-masked]> wrote:
> From: Amir Vadai <[email-masked]>
> 
> Extract _ip_tun_rx_dst() and _ipv6_tun_rx_dst() out of ip_tun_rx_dst()
> and ipv6_tun_rx_dst(), to be used without supplying an skb.

Per this v3, the newly introduced helpers ate named _ip_tun_set_dst and
_ipv6_tun_set_dst - better alter the log message to reflect that.

> +static inline struct metadata_dst *
> +_ipv6_tun_set_dst(const struct in6_addr saddr, const struct in6_addr daddr,
> +		  __u8 tos, __u8 ttl, __be32 label, __be16 flags,
> +		  __be64 tunnel_id, int md_size)
> +{

Any reason not passing in6_addr pointers, as suggested?
This is the common practice for ipv6 address parameters.

Thanks,
Shmulik