From: Arnd Bergmann <arnd@arndb•de>
To: Baoyou Xie <baoyou.xie@linaro•org>
Cc: isdn@linux-pingi•de, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, xie.baoyou@zte•com.cn
Subject: Re: [PATCH] mISDN: mark symbols static where possible
Date: Mon, 29 Aug 2016 14:15:41 +0200 [thread overview]
Message-ID: <201608291415.41294.arnd@arndb.de> (raw)
In-Reply-To: <1472471973-23041-1-git-send-email-baoyou.xie@linaro.org>
On Monday 29 August 2016, Baoyou Xie wrote:
> We get 1 warning when biuld kernel with W=1:
> drivers/isdn/hardware/mISDN/w6692.c:851:6: warning: no previous prototype for 'initW6692' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is declared
> and don't need a declaration, but can be made static.
> so this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro•org>
> ---
> drivers/isdn/hardware/mISDN/w6692.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
The patch looks good, but now you have sent two different patches with the same subject
line. Since this is just one driver and each instance is a trivial change, I'd suggest
doing a single combined patch for them.
Similarly, when you have multiple patches within one subsystem (e.g. two different scsi
drivers), it helps to have a series of patches as you did with the ASoC patches.
Arnd
next prev parent reply other threads:[~2016-08-29 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 11:59 [PATCH] mISDN: mark symbols static where possible Baoyou Xie
2016-08-29 12:15 ` Arnd Bergmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-08-29 12:31 Baoyou Xie
2016-08-29 12:14 Baoyou Xie
2016-09-01 4:02 ` David Miller
2016-08-29 11:49 Baoyou Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201608291415.41294.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=baoyou.xie@linaro$(echo .)org \
--cc=isdn@linux-pingi$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xie.baoyou@zte$(echo .)com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox