From: Jiri Pirko <jiri@resnulli•us>
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: netdev@vger•kernel.org, yotamg@mellanox•com, eladr@mellanox•com,
idosch@mellanox•com, nogahf@mellanox•com, ogerlitz@mellanox•com
Subject: Re: [patch iproute2 1/2] tc: Add support for the matchall traffic classifier.
Date: Mon, 29 Aug 2016 20:40:45 +0200 [thread overview]
Message-ID: <20160829184045.GA2012@nanopsycho.orion> (raw)
In-Reply-To: <20160829110321.78959dc8@xeon-e3>
Mon, Aug 29, 2016 at 08:03:21PM CEST, stephen@networkplumber•org wrote:
>On Mon, 22 Aug 2016 13:56:25 +0200
>Jiri Pirko <jiri@resnulli•us> wrote:
>
>> From: Yotam Gigi <yotamg@mellanox•com>
>>
>> The matchall classifier matches every packet and allows the user to apply
>> actions on it. In addition, it supports the skip_sw and skip_hw (as can
>> be found on u32 and flower filter) that direct the kernel to skip the
>> software/hardware processing of the actions.
>>
>> This filter is very useful in usecases where every packet should be
>> matched. For example, packet mirroring (SPAN) can be setup very easily
>> using that filter.
>>
>> Signed-off-by: Yotam Gigi <yotamg@mellanox•com>
>> Signed-off-by: Jiri Pirko <jiri@mellanox•com>
>
>I am not a checkpatch purist, but these two should be addressed.
>
>
>WARNING: unnecessary whitespace before a quoted newline
>#81: FILE: tc/f_matchall.c:29:
>+ fprintf(stderr, "Usage: ... matchall [skip_sw | skip_hw] \n");
>
>WARNING: braces {} are not necessary for single statement blocks
>#185: FILE: tc/f_matchall.c:133:
>+ if (tb[TCA_MATCHALL_ACT]) {
>+ tc_print_action(f, tb[TCA_MATCHALL_ACT]);
>+ }
will fix and send v2. Thanks.
next prev parent reply other threads:[~2016-08-29 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 11:56 [patch iproute2 0/2] Add matchall support to tc Jiri Pirko
2016-08-22 11:56 ` [patch iproute2 1/2] tc: Add support for the matchall traffic classifier Jiri Pirko
2016-08-29 18:03 ` Stephen Hemminger
2016-08-29 18:40 ` Jiri Pirko [this message]
2016-08-22 11:56 ` [patch iproute2 2/2] tc: man: Add man entry for the matchall classifier Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829184045.GA2012@nanopsycho.orion \
--to=jiri@resnulli$(echo .)us \
--cc=eladr@mellanox$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nogahf@mellanox$(echo .)com \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=yotamg@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox