public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Raju Lakkaraju <Raju.Lakkaraju@microsemi•com>
To: Andrew Lunn <andrew@lunn•ch>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
	"f.fainelli@gmail•com" <f.fainelli@gmail•com>,
	Allan Nielsen <Allan.Nielsen@microsemi•com>
Subject: Re: [PATCH 1/4] net: phy: Add Edge-rate driver for Microsemi PHYs.
Date: Thu, 8 Sep 2016 14:36:57 +0530	[thread overview]
Message-ID: <20160908090655.GB4134@microsemi.com> (raw)
In-Reply-To: <20160824125934.GC13406@lunn.ch>

Hi Andrew,

Thank you for review the code and valuable comments.
I accepted your review comments.
I too use the Device Tree for Edge-rate and MAC interface 
configuration.

Thanks,
Raju.

On Wed, Aug 24, 2016 at 02:59:34PM +0200, Andrew Lunn wrote:
> EXTERNAL EMAIL
> 
> 
> On Wed, Aug 24, 2016 at 12:20:03PM +0000, Raju Lakkaraju wrote:
> > From: Nagaraju Lakkaraju <Raju.Lakkaraju@microsemi•com>
> >
> > Edge rate control support will be added for VSC 85xx Microsemi PHYs.
> 
> > diff --git a/include/linux/phy.h b/include/linux/phy.h
> > index 2d24b28..8ec4c09 100644
> > --- a/include/linux/phy.h
> > +++ b/include/linux/phy.h
> > @@ -586,6 +586,8 @@ struct phy_driver {
> >         void (*get_strings)(struct phy_device *dev, u8 *data);
> >         void (*get_stats)(struct phy_device *dev,
> >                           struct ethtool_stats *stats, u64 *data);
> > +       int (*phy_features_set)(struct phy_device *dev);
> > +       int (*phy_features_get)(struct phy_device *dev);
> >  };
> 
> Now we need the missing cover note what should be in 0/4.  What is the
> big picture? How are these two functions supposed to be used? Is there
> going to be a user space API via netlink? Should the MAC driver
> somehow call these functions? Are you going to extend the phylib with
> code to call these?
> 
> Those are all general questions for these two functions.
> 
> Now specifically for edge control, why did you decide not to use
> device tree? Both the micrel and renesas phy driver uses device tree
> for skew control. You need to explain why you need to do something
> different to other drivers.
> 
>           Thanks
>                 Andrew
> 
> 

next prev parent reply	other threads:[~2016-09-08  9:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24 12:20 [PATCH 1/4] net: phy: Add Edge-rate driver for Microsemi PHYs Raju Lakkaraju
2016-08-24 12:59 ` Andrew Lunn
2016-09-08  9:06   ` Raju Lakkaraju [this message]
2016-09-08  9:17   ` [PATCH v2 net-next 0/2] net: phy: Add Edge-rate, MAC-IF " Raju Lakkaraju
2016-09-08  9:17     ` [PATCH v2 net-next 1/2] net: phy: Add Edge-rate " Raju Lakkaraju
2016-09-08 13:14       ` Andrew Lunn
2016-09-09  5:40         ` Raju Lakkaraju
2016-09-09 13:18           ` Andrew Lunn
2016-09-15 10:26             ` Raju Lakkaraju
2016-09-08  9:17     ` [PATCH v2 net-next 2/2] net: phy: Add MAC-IF " Raju Lakkaraju
2016-09-08 13:27       ` Andrew Lunn
2016-09-09  5:53         ` Raju Lakkaraju
2016-09-09 12:03           ` Andrew Lunn
2016-09-15 10:28             ` Raju Lakkaraju
2016-09-08 12:59     ` [PATCH v2 net-next 0/2] net: phy: Add Edge-rate, " Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160908090655.GB4134@microsemi.com \
    --to=raju.lakkaraju@microsemi$(echo .)com \
    --cc=Allan.Nielsen@microsemi$(echo .)com \
    --cc=andrew@lunn$(echo .)ch \
    --cc=f.fainelli@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox