From: Jesper Dangaard Brouer <brouer@redhat•com>
To: Brenden Blanco <bblanco@plumgrid•com>
Cc: brouer@redhat•com, netdev@vger•kernel.org, tariqt@mellanox•com,
Eric Dumazet <eric.dumazet@gmail•com>,
tom@herbertland•com, rana.shahot@gmail•com,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full
Date: Sat, 17 Sep 2016 16:46:50 +0200 [thread overview]
Message-ID: <20160917164650.53e68314@redhat.com> (raw)
In-Reply-To: <20160916204350.GA20076@gmail.com>
On Fri, 16 Sep 2016 13:43:50 -0700
Brenden Blanco <bblanco@plumgrid•com> wrote:
> On Fri, Sep 16, 2016 at 10:36:12PM +0200, Jesper Dangaard Brouer wrote:
> > The XDP_TX action can fail transmitting the frame in case the TX ring
> > is full or port is down. In case of TX failure it should drop the
> > frame, and not as now call 'break' which is the same as XDP_PASS.
> >
> > Fixes: 9ecc2d86171a ("net/mlx4_en: add xdp forwarding and data write support")
> > Signed-off-by: Jesper Dangaard Brouer <brouer@redhat•com>
>
> You could in theory have also tried to recycle the page instead of
> dropping it, but that's probably not worth optimizing when tx is backed
> up, as you'll only save a handful of page_put's. The code to do so
> wouldn't have been pretty.
Yes, we could (and perhaps should) recycle the page instead. But as you
also mention it would not look pretty. I'll send a V3, as XDPs primary
concern is performance.
> Reviewed-by: Brenden Blanco <bblanco@plumgrid•com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2016-09-17 14:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 20:36 [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full Jesper Dangaard Brouer
2016-09-16 20:37 ` Jesper Dangaard Brouer
2016-09-16 20:43 ` Brenden Blanco
2016-09-17 14:46 ` Jesper Dangaard Brouer [this message]
2016-09-17 15:48 ` [net PATCH V3] " Jesper Dangaard Brouer
2016-09-18 8:30 ` Tariq Toukan
2016-09-19 5:39 ` David Miller
2016-09-19 7:40 ` [net-next PATCH] mlx4: add missed recycle opportunity for XDP_TX on TX failure Jesper Dangaard Brouer
2016-09-19 10:54 ` Tariq Toukan
2016-09-19 14:28 ` Eric Dumazet
2016-09-19 15:46 ` [net-next PATCH V2] " Jesper Dangaard Brouer
2016-09-20 8:58 ` David Miller
2016-09-19 15:57 ` [net-next PATCH] " Jesper Dangaard Brouer
2016-09-19 7:42 ` [net PATCH V3] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full Jesper Dangaard Brouer
2016-09-19 5:32 ` [net PATCH] " David Miller
-- strict thread matches above, loose matches on Subject: below --
2016-09-16 19:47 Jesper Dangaard Brouer
2016-09-16 20:00 ` Eric Dumazet
2016-09-16 20:29 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160917164650.53e68314@redhat.com \
--to=brouer@redhat$(echo .)com \
--cc=bblanco@plumgrid$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rana.shahot@gmail$(echo .)com \
--cc=tariqt@mellanox$(echo .)com \
--cc=tom@herbertland$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox