From: Jason Gunthorpe <jgunthorpe@obsidianresearch•com>
To: Ram Amrani <Ram.Amrani@cavium•com>
Cc: davem@davemloft•net, dledford@redhat•com, Ariel.Elior@cavium•com,
Michal.Kalderon@cavium•com, Yuval.Mintz@cavium•com,
rajesh.borundia@cavium•com, linux-rdma@vger•kernel.org,
netdev@vger•kernel.org
Subject: Re: [RFC v2 04/12] qedr: Add support for user context verbs
Date: Tue, 20 Sep 2016 09:27:29 -0600 [thread overview]
Message-ID: <20160920152729.GC32020@obsidianresearch.com> (raw)
In-Reply-To: <1474367764-9555-5-git-send-email-Ram.Amrani@cavium.com>
On Tue, Sep 20, 2016 at 01:35:56PM +0300, Ram Amrani wrote:
> +++ b/include/uapi/rdma/providers/qedr-abi.h
> @@ -0,0 +1,27 @@
> +/* QLogic qed NIC Driver
> + * Copyright (c) 2015 QLogic Corporation
> + *
> + * This software is available under the terms of the GNU General Public License
> + * (GPL) Version 2, available from the file COPYING in the main directory of
> + * this source tree.
> + */
> +#ifndef __QEDR_USER_H__
> +#define __QEDR_USER_H__
> +
> +#define QEDR_ABI_VERSION (6)
> +
> +/* user kernel communication data structures. */
> +
> +struct qedr_alloc_ucontext_resp {
> + u64 db_pa;
> + u32 db_size;
> +
> + u32 max_send_wr;
> + u32 max_recv_wr;
> + u32 max_srq_wr;
> + u32 sges_per_send_wr;
> + u32 sges_per_recv_wr;
> + u32 sges_per_srq_wr;
uapi headers need the __ varients and the #include <linux/types.h>
Follow what Leon has done.
> + int max_cqes;
Do not use int here.
Is there really only 1 struct? Your driver never uses udata for
anything else?
Jason
next prev parent reply other threads:[~2016-09-20 15:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 10:35 [RFC v2 00/11] QLogic RDMA Driver (qedr) RFC Ram Amrani
2016-09-20 10:35 ` [RFC v2 01/12] qed: Add LL2 Ram Amrani
2016-09-20 10:35 ` [RFC v2 03/12] qedr: Add support for RoCE HW init Ram Amrani
[not found] ` <1474367764-9555-1-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-09-20 10:35 ` [RFC v2 02/12] qedr: Add RoCE driver framework Ram Amrani
2016-09-20 10:35 ` [RFC v2 04/12] qedr: Add support for user context verbs Ram Amrani
2016-09-20 15:27 ` Jason Gunthorpe [this message]
2016-09-21 14:20 ` Amrani, Ram
[not found] ` <1474367764-9555-5-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-09-20 16:45 ` Leon Romanovsky
[not found] ` <20160920164556.GS26673-2ukJVAZIZ/Y@public.gmane.org>
2016-09-21 14:18 ` Amrani, Ram
2016-09-20 10:35 ` [RFC v2 05/12] qedr: Add support for PD,PKEY and CQ verbs Ram Amrani
2016-09-20 10:35 ` [RFC v2 07/12] qedr: Add support for memory registeration verbs Ram Amrani
2016-09-21 19:53 ` Sagi Grimberg
2016-09-20 10:36 ` [RFC v2 09/12] qedr: Add LL2 RoCE interface Ram Amrani
2016-09-20 10:36 ` [RFC v2 10/12] qedr: Add GSI support Ram Amrani
2016-09-20 12:11 ` [RFC v2 00/11] QLogic RDMA Driver (qedr) RFC Leon Romanovsky
[not found] ` <20160920121151.GK26673-2ukJVAZIZ/Y@public.gmane.org>
2016-09-20 13:33 ` Elior, Ariel
[not found] ` <CY1PR0701MB133773B2CB71FA6362CADCFF90F70-UpKza+2NMNLi6bjPjkn3FE5OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-09-20 16:23 ` Leon Romanovsky
[not found] ` <20160920162306.GP26673-2ukJVAZIZ/Y@public.gmane.org>
2016-09-21 14:19 ` Amrani, Ram
2016-09-20 10:35 ` [RFC v2 06/12] qedr: Add support for QP verbs Ram Amrani
[not found] ` <1474367764-9555-7-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-09-20 15:28 ` Jason Gunthorpe
[not found] ` <20160920152849.GD32020-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-21 14:23 ` Amrani, Ram
[not found] ` <SN1PR07MB2207B94372F7A910C0E6AF0AF8F60-mikhvbZlbf8TSoR2DauN2+FPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-09-21 15:55 ` Jason Gunthorpe
[not found] ` <20160921155509.GC1510-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-22 6:51 ` Amrani, Ram
2016-09-20 16:30 ` Leon Romanovsky
2016-09-21 14:15 ` Amrani, Ram
2016-09-22 13:32 ` Leon Romanovsky
2016-09-20 10:36 ` [RFC v2 08/12] qedr: Add support for data path Ram Amrani
2016-09-20 10:36 ` [RFC v2 11/12] qedr: Add events support and register IB device Ram Amrani
2016-09-20 10:36 ` [RFC v2 12/12] IB/core: add a protection to ib_get_dma_mr Ram Amrani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920152729.GC32020@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch$(echo .)com \
--cc=Ariel.Elior@cavium$(echo .)com \
--cc=Michal.Kalderon@cavium$(echo .)com \
--cc=Ram.Amrani@cavium$(echo .)com \
--cc=Yuval.Mintz@cavium$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dledford@redhat$(echo .)com \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rajesh.borundia@cavium$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox