Subject: Re: [RFC v2 06/12] qedr: Add support for QP verbs

From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Date: Tue, 20 Sep 2016 09:28:49 -0600

On Tue, Sep 20, 2016 at 01:35:58PM +0300, Ram Amrani wrote:
> +++ b/include/uapi/rdma/providers/qedr-abi.h
> @@ -43,4 +43,39 @@ struct qedr_create_cq_uresp {
>         u16 icid;
>  };

Ugh, each patch keeps adding to this?

> +struct qedr_create_qp_ureq {
> +       u32 qp_handle_hi;
> +       u32 qp_handle_lo;
> +
> +       /* SQ */
> +       /* user space virtual address of SQ buffer */
> +       u64 sq_addr;
> +
> +       /* length of SQ buffer */
> +       size_t sq_len;

Do not use size_t, that is just asking for 32/64 bit interop problems.

> +struct qedr_create_qp_uresp {
> +       u32 qp_id;
> +       int atomic_supported;

int again, etc. You get the idea.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email-masked]
More majordomo info at  http://vger.kernel.org/majordomo-info.html