From: Jiri Pirko <jiri@resnulli•us>
To: David Ahern <dsa@cumulusnetworks•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net, idosch@mellanox•com,
eladr@mellanox•com, yotamg@mellanox•com, nogahf@mellanox•com,
ogerlitz@mellanox•com, roopa@cumulusnetworks•com,
nikolay@cumulusnetworks•com, linville@tuxdriver•com,
andy@greyhouse•net, f.fainelli@gmail•com, jhs@mojatatu•com,
vivien.didelot@savoirfairelinux•com, andrew@lunn•ch,
ivecera@redhat•com, kaber@trash•net, john@phrozen•org
Subject: Re: [patch net-next 3/6] mlxsw: spectrum_router: Use FIB notifications instead of switchdev calls
Date: Thu, 22 Sep 2016 17:05:51 +0200 [thread overview]
Message-ID: <20160922150551.GE1830@nanopsycho.orion> (raw)
In-Reply-To: <5206ebd6-89c1-ec44-8b98-c5109ebe6140@cumulusnetworks.com>
Thu, Sep 22, 2016 at 04:58:20PM CEST, dsa@cumulusnetworks•com wrote:
>On 9/21/16 5:53 AM, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@mellanox•com>
>>
>> Until now, in order to offload a FIB entry to HW we use switchdev op.
>> However that has limits. Mainly in case we need to make the HW aware of
>> all route prefixes configured in kernel. HW needs to know those in order
>> to properly trap appropriate packets and pass the to kernel to do
>> the forwarding. Abort mechanism is now handled within the mlxsw driver.
>>
>> Signed-off-by: Jiri Pirko <jiri@mellanox•com>
>> ---
>> drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 9 +-
>> .../net/ethernet/mellanox/mlxsw/spectrum_router.c | 386 ++++++++++++---------
>> .../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 9 -
>> 3 files changed, 216 insertions(+), 188 deletions(-)
>>
>>
>
>
>Make the move to fib notifiers and the removal of switchdev code separate patches. It will make the fib notifier change easier to follow.
Since I'm changing one iface by another, I don't see how I can split it.
next prev parent reply other threads:[~2016-09-22 15:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 11:53 [patch net-next 0/6] fib offload: switch to notifier Jiri Pirko
2016-09-21 11:53 ` [patch net-next 1/6] fib: introduce FIB notification infrastructure Jiri Pirko
2016-09-22 5:13 ` Ido Schimmel
2016-09-22 9:43 ` Jiri Pirko
2016-09-21 11:53 ` [patch net-next 2/6] fib: introduce FIB info offload flag helpers Jiri Pirko
2016-09-22 5:14 ` Ido Schimmel
2016-09-21 11:53 ` [patch net-next 3/6] mlxsw: spectrum_router: Use FIB notifications instead of switchdev calls Jiri Pirko
2016-09-22 6:51 ` Ido Schimmel
2016-09-22 9:47 ` Jiri Pirko
2016-09-22 14:58 ` David Ahern
2016-09-22 15:05 ` Jiri Pirko [this message]
2016-09-22 15:12 ` David Ahern
2016-09-21 11:53 ` [patch net-next 4/6] rocker: use " Jiri Pirko
2016-09-21 11:53 ` [patch net-next 5/6] switchdev: remove FIB offload infrastructure Jiri Pirko
2016-09-22 7:25 ` Ido Schimmel
2016-09-22 12:49 ` Jiri Pirko
2016-09-21 11:53 ` [patch net-next 6/6] doc: update switchdev L3 section Jiri Pirko
2016-09-22 7:31 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922150551.GE1830@nanopsycho.orion \
--to=jiri@resnulli$(echo .)us \
--cc=andrew@lunn$(echo .)ch \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dsa@cumulusnetworks$(echo .)com \
--cc=eladr@mellanox$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=ivecera@redhat$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=john@phrozen$(echo .)org \
--cc=kaber@trash$(echo .)net \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@cumulusnetworks$(echo .)com \
--cc=nogahf@mellanox$(echo .)com \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
--cc=yotamg@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox