From: Greg KH <gregkh@linuxfoundation•org>
To: Chris Roth <chris.roth@usask•ca>
Cc: linux-usb@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH v2] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.
Date: Tue, 27 Sep 2016 17:40:26 +0200 [thread overview]
Message-ID: <20160927154026.GA887@kroah.com> (raw)
In-Reply-To: <CAPZMiRa6=So14ic8SMSkbHdrVH8-7vA1+Wg_hWJoAgr8G_mhyw@mail.gmail.com>
On Mon, Sep 26, 2016 at 03:56:59PM -0600, Chris Roth wrote:
> I'm not sure what I'm doing wrong:
>
> I'm trying to get the from statement to read original author (Allan
> Chou) first, and then me (Chris Roth) second. I've used the following
> two commands:
>
> git format-patch -o /tmp/ --subject-prefix="PATCH v2" --from="Allan
> Chou <allan@asix•com.tw>" HEAD^
>
> and
>
> git send-email --to linux-usb@vger•kernel.org --to
> netdev@vger•kernel.org --to linux-kernel@vger•kernel.org --from="Allan
> Chou <allan@asix•com.tw>"
> /tmp/0001-Net-Driver-Add-Cypress-GX3-VID-04b4-PID-3610.patch
>
> I thought that adding the --from portions to the git format-patch and
> git send-email commands would force the addition of Allan to the top
> of the patch, but it hasn't. Can anyone tell me specifically how I
> need to change these commands in order to get the desired result? Then
> I'll submit a PATCH v3.
Take the patch that you have, hand-edit it with your favorite editor to
have the correct headers and signed-off-by and other fields, and then
use git send-email without the --from line, and you should be fine.
thanks,
greg k-h
prev parent reply other threads:[~2016-09-27 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 21:48 [PATCH v2] Net Driver: Add Cypress GX3 VID=04b4 PID=3610 Allan Chou
2016-09-26 21:56 ` Chris Roth
2016-09-27 15:40 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927154026.GA887@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=chris.roth@usask$(echo .)ca \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox