From: Greg KH <gregkh@linuxfoundation•org>
To: Zach Brown <zach.brown@ni•com>
Cc: devel@driverdev•osuosl.org, florian.c.schilhabel@googlemail•com,
f.fainelli@gmail•com, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, mlindner@marvell•com,
Larry.Finger@lwfinger•net
Subject: Re: [RFC v2 2/4] staging: rtl8712: Change _LED_STATE enum in rtl871x driver to avoid conflicts with LED namespace
Date: Wed, 28 Sep 2016 11:27:41 +0200 [thread overview]
Message-ID: <20160928092741.GA16646@kroah.com> (raw)
In-Reply-To: <1475013111-18942-3-git-send-email-zach.brown@ni.com>
On Tue, Sep 27, 2016 at 04:51:49PM -0500, Zach Brown wrote:
> Adding led support for phy causes namespace conflicts for some
> phy drivers.
>
> The rtl871 driver declared an enum for representing LED states. The enum
> contains constant LED_OFF which conflicted with declaration found in
> linux/leds.h. LED_OFF changed to LED_STATE_OFF
> In order to avoid a possible future collision LED_ON was changed to
> LED_STATE_ON as well.
>
> Signed-off-by: Zach Brown <zach.brown@ni•com>
> ---
> drivers/staging/rtl8712/rtl8712_led.c | 388 +++++++++++++++++-----------------
> 1 file changed, 194 insertions(+), 194 deletions(-)
Ick, messy. I'll be glad to take this patch now to make your life
easier in the future.
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-28 9:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 21:51 [RFC v2 0/4] Add support for led triggers on phy link state change Zach Brown
2016-09-27 21:51 ` [RFC v2 1/4] skge: Change LED_OFF to LED_REG_OFF in marvel skge driver to avoid conflicts with leds namespace Zach Brown
2016-09-27 21:51 ` [RFC v2 2/4] staging: rtl8712: Change _LED_STATE enum in rtl871x driver to avoid conflicts with LED namespace Zach Brown
2016-09-28 9:27 ` Greg KH [this message]
2016-09-27 21:51 ` [RFC v2 3/4] phy: Encapsulate actions performed during link state changes into function phy_adjust_link Zach Brown
2016-09-27 21:51 ` [RFC v2 4/4] phy, leds: add support for led triggers on phy link state change Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928092741.GA16646@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=Larry.Finger@lwfinger$(echo .)net \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=f.fainelli@gmail$(echo .)com \
--cc=florian.c.schilhabel@googlemail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mlindner@marvell$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=zach.brown@ni$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox