From: Jiri Benc <jbenc@redhat•com>
To: pravin shelar <pshelar@ovn•org>
Cc: Linux Kernel Network Developers <netdev@vger•kernel.org>,
David Ahern <dsa@cumulusnetworks•com>
Subject: Re: [PATCH net-next v2 2/3] mpls: move mpls_hdr to a common location
Date: Fri, 30 Sep 2016 19:51:59 +0200 [thread overview]
Message-ID: <20160930195159.5b7eed00@griffin> (raw)
In-Reply-To: <CAOrHB_BJqka5HGpeJ1GF42X2kQOmzrLY_LQt4Td6zrAX84Fjow@mail.gmail.com>
On Fri, 30 Sep 2016 10:43:42 -0700, pravin shelar wrote:
> There is already struct mpls_label defined in uapi mpls header file.
> Is there reason for not using it here?
I think this should be unified as well. But it's for a different patch
not related to this patchset. This patch just moves the existing
mpls_hdr and mpls_shim_hdr definition to a new place.
In general, I think the mpls code deserves a round of overall cleanups.
It should not block this patchset, though. It can be considered as a
step towards that goal.
Jiri
next prev parent reply other threads:[~2016-09-30 17:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 17:08 [PATCH net-next v2 0/3] openvswitch: mpls fix and clean up Jiri Benc
2016-09-30 17:08 ` [PATCH net-next v2 1/3] openvswitch: mpls: set network header correctly on key extract Jiri Benc
2016-09-30 17:08 ` [PATCH net-next v2 2/3] mpls: move mpls_hdr to a common location Jiri Benc
2016-09-30 17:14 ` David Ahern
2016-09-30 17:43 ` pravin shelar
2016-09-30 17:51 ` Jiri Benc [this message]
2016-09-30 18:20 ` pravin shelar
2016-09-30 17:08 ` [PATCH net-next v2 3/3] openvswitch: use mpls_hdr Jiri Benc
2016-09-30 18:20 ` pravin shelar
2016-10-03 6:00 ` [PATCH net-next v2 0/3] openvswitch: mpls fix and clean up David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930195159.5b7eed00@griffin \
--to=jbenc@redhat$(echo .)com \
--cc=dsa@cumulusnetworks$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pshelar@ovn$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox