Subject: Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change

From: Zach Brown <[email-masked]>
Date: Wed, 12 Oct 2016 10:57:58 -0500

On Mon, Oct 10, 2016 at 02:03:32AM -0700, Florian Fainelli wrote:
> > +
> > +#ifdef CONFIG_LED_TRIGGER_PHY
> > +
> > +#include <linux/leds.h>
> > +#include <linux/phy.h>
> > +
> > +#define PHY_LINK_LED_MAX_TRIGGERS	5
> > +#define PHY_LED_TRIGGER_SPEED_SUFFIX_SIZE	7
> > +#define PHY_MII_BUS_ID_SIZE	(20 - 3)
> 
> This particular constant may be something worth moving to
> include/linux/phy.h eventually.
> -- 
> Florian

MII_BUS_ID_SIZE is defined in include/linux/phy.h but it's defined after
phy_led_triggers.h is included so phy_led_triggers.h doesn't have access.
I could move the definition of MII_BUS_ID_SIZE above the include, but that
seemed ugly. Do you have any suggestions?