public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Andrew Lunn <andrew@lunn•ch>
To: "Allan W. Nielsen" <allan.nielsen@microsemi•com>
Cc: netdev@vger•kernel.org, f.fainelli@gmail•com,
	raju.lakkaraju@microsemi•com, cphealy@gmail•com, robh@kernel•org
Subject: Re: [PATCH ethtool 2/2] Ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY downshift
Date: Fri, 4 Nov 2016 12:59:37 +0100	[thread overview]
Message-ID: <20161104115937.GH13959@lunn.ch> (raw)
In-Reply-To: <1478255805-25823-3-git-send-email-allan.nielsen@microsemi.com>

Hi Allen

> +++ b/ethtool.8.in
> @@ -340,6 +340,14 @@ ethtool \- query or control network driver and hardware settings
>  .B2 tx-lpi on off
>  .BN tx-timer
>  .BN advertise
> +.HP
> +.B ethtool \-\-set\-phy\-tunable
> +.I devname
> +.B3 downshift on off N
> +.HP

I don't think there is any other option which is on|off|N. The general
pattern would be

--set-phy-tunable downshift on|off [count N]

With count being optional.

This also allows avoiding the ambiguity of what

--set-phy-tunable downshift 0

means. To me, that means downshift after 0 retries. But it actually
seems to mean never downshift. You can then error out when somebody
does

--set-phy-tunable downshift on count 0
or
--set-phy-tunable downshift off count 42

Please also add a few sentences about what downshift is, and what N
means. Is it tries, or retries?

Thanks
       Andrew

next prev parent reply	other threads:[~2016-11-04 11:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-04 10:36 [PATCH ethtool 0/2] Adding downshift support to ethtool Allan W. Nielsen
2016-11-04 10:36 ` [PATCH ethtool 1/2] ethtool-copy.h:sync with net Allan W. Nielsen
2016-11-04 10:36 ` [PATCH ethtool 2/2] Ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY downshift Allan W. Nielsen
2016-11-04 11:59   ` Andrew Lunn [this message]
2016-11-04 13:28     ` Allan W. Nielsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161104115937.GH13959@lunn.ch \
    --to=andrew@lunn$(echo .)ch \
    --cc=allan.nielsen@microsemi$(echo .)com \
    --cc=cphealy@gmail$(echo .)com \
    --cc=f.fainelli@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=raju.lakkaraju@microsemi$(echo .)com \
    --cc=robh@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox