From: "Allan W. Nielsen" <allan.nielsen@microsemi•com>
To: Andrew Lunn <andrew@lunn•ch>
Cc: <netdev@vger•kernel.org>, <f.fainelli@gmail•com>,
<raju.lakkaraju@microsemi•com>, <cphealy@gmail•com>,
<robh@kernel•org>
Subject: Re: [PATCH net-next 2/5] ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE
Date: Fri, 4 Nov 2016 14:31:01 +0100 [thread overview]
Message-ID: <20161104133101.GB11277@microsemi.com> (raw)
In-Reply-To: <20161104121332.GJ13959@lunn.ch>
On 04/11/16 13:13, Andrew Lunn wrote:
> On Fri, Nov 04, 2016 at 11:35:39AM +0100, Allan W. Nielsen wrote:
> > From: Raju Lakkaraju <Raju.Lakkaraju@microsemi•com>
> >
> > Adding get_tunable/set_tunable function pointer to the phy_driver
> > structure, and uses these function pointers to implement the
> > ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE ioctls.
> For consistency, it would also be nice to add code in
> __ethtool_get_strings().
Okay, we add add that, and I assume you also want ethtool to use it when the
"-k|--show-features" options is invoked?
Are there other cases where this should be used?
/Allan
next prev parent reply other threads:[~2016-11-04 13:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 10:35 [PATCH net-next 0/5] Adding PHY-Tunables and downshift support Allan W. Nielsen
2016-11-04 10:35 ` [PATCH net-next 1/5] ethtool: (uapi) Add ETHTOOL_PHY_GTUNABLE and ETHTOOL_PHY_STUNABLE Allan W. Nielsen
2016-11-04 12:03 ` Andrew Lunn
2016-11-04 12:18 ` Allan W. Nielsen
2016-11-04 12:29 ` Andrew Lunn
2016-11-04 10:35 ` [PATCH net-next 2/5] ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE Allan W. Nielsen
2016-11-04 12:13 ` Andrew Lunn
2016-11-04 13:31 ` Allan W. Nielsen [this message]
2016-11-04 10:35 ` [PATCH net-next 3/5] ethtool: (uapi) Add ETHTOOL_PHY_DOWNSHIFT to PHY tunables Allan W. Nielsen
2016-11-04 10:35 ` [PATCH net-next 4/5] ethtool: Core impl for ETHTOOL_PHY_DOWNSHIFT tunable Allan W. Nielsen
2016-11-04 10:35 ` [PATCH net-next 5/5] net: phy: Add downshift get/set support in Microsemi PHYs driver Allan W. Nielsen
2016-11-04 12:27 ` Andrew Lunn
2016-11-04 13:42 ` Allan W. Nielsen
2016-11-04 13:55 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161104133101.GB11277@microsemi.com \
--to=allan.nielsen@microsemi$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=cphealy@gmail$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=raju.lakkaraju@microsemi$(echo .)com \
--cc=robh@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox