Subject: Re: [PATCH net v2 2/4] net: ethernet: ti: cpsw: fix device and of_node leaks

From: Johan Hovold <[email-masked]>
Date: Wed, 9 Nov 2016 10:58:25 +0100

On Tue, Nov 08, 2016 at 05:19:29PM -0600, Grygorii Strashko wrote:
> 
> 
> On 11/03/2016 12:40 PM, Johan Hovold wrote:
> > Make sure to drop the references taken by of_get_child_by_name() and
> > bus_find_device() before returning from cpsw_phy_sel().
> >
> > Note that holding a reference to the cpsw-phy-sel device does not
> > prevent the devres-managed private data from going away.
> >
> > Fixes: 5892cd135e16 ("drivers: net: cpsw-phy-sel: Add new driver...")
> > Cc: Mugunthan V N <[email-masked]>
> > Cc: Grygorii Strashko <[email-masked]>
> > Cc: [email-masked]
> > Signed-off-by: Johan Hovold <[email-masked]>
> > ---
> 
> Reviewed-by: Grygorii Strashko <[email-masked]>

Thanks for the review. Note that David has already applied these, though.

Johan