From: Jiri Benc <jbenc@redhat•com>
To: Arnd Bergmann <arnd@arndb•de>
Cc: "David S. Miller" <davem@davemloft•net>,
Hannes Frederic Sowa <hannes@stressinduktion•org>,
Alexander Duyck <aduyck@mirantis•com>,
pravin shelar <pshelar@ovn•org>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] vxlan: hide unused local variable
Date: Wed, 9 Nov 2016 17:19:48 +0100 [thread overview]
Message-ID: <20161109171948.4bbc9615@griffin> (raw)
In-Reply-To: <20161107211017.857340-1-arnd@arndb.de>
On Mon, 7 Nov 2016 22:09:07 +0100, Arnd Bergmann wrote:
> A bugfix introduced a harmless warning in v4.9-rc4:
>
> drivers/net/vxlan.c: In function 'vxlan_group_used':
> drivers/net/vxlan.c:947:21: error: unused variable 'sock6' [-Werror=unused-variable]
>
> This hides the variable inside of the same #ifdef that is
> around its user. The extraneous initialization is removed
> at the same time, it was accidentally introduced in the
> same commit.
>
> Fixes: c6fcc4fc5f8b ("vxlan: avoid using stale vxlan socket.")
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
I think this should be applied instead of Pravin's patch. It fixes just
the one problem, contains the proper Fixes: tag and addresses net.git.
Acked-by: Jiri Benc <jbenc@redhat•com>
next prev parent reply other threads:[~2016-11-09 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 21:09 [PATCH] vxlan: hide unused local variable Arnd Bergmann
[not found] ` <CAOrHB_BRnCmka_cQ1ALnOC1Yta7c8_KWrQ7tzr2tX2fbvOjs7g@mail.gmail.com>
2016-11-07 22:21 ` Arnd Bergmann
2016-11-08 0:25 ` Pravin Shelar
2016-11-08 1:18 ` David Miller
2016-11-09 16:19 ` Jiri Benc [this message]
2016-11-10 0:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109171948.4bbc9615@griffin \
--to=jbenc@redhat$(echo .)com \
--cc=aduyck@mirantis$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=hannes@stressinduktion$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pshelar@ovn$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox