From: Andrew Lunn <andrew@lunn•ch>
To: Stefan Eichenberger <stefan.eichenberger@netmodule•com>
Cc: Stefan Eichenberger <eichest@gmail•com>,
vivien.didelot@savoirfairelinux•com, f.fainelli@gmail•com,
netdev@vger•kernel.org
Subject: Re: [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097
Date: Wed, 23 Nov 2016 18:40:40 +0100 [thread overview]
Message-ID: <20161123174040.GE8760@lunn.ch> (raw)
In-Reply-To: <20161123171441.GE12698@gruene.netmodule.intranet>
On Wed, Nov 23, 2016 at 06:14:41PM +0100, Stefan Eichenberger wrote:
> On Wed, Nov 23, 2016 at 05:59:49PM +0100, Andrew Lunn wrote:
> > On Wed, Nov 23, 2016 at 05:54:40PM +0100, Stefan Eichenberger wrote:
> > > Packets with unknown destination addresses are not forwarded to the cpu
> > > port on mv88e6097 based switches (e.g. MV88E6097) at the moment. This
> > > commit enables PORT_CONTROL_FORWARD_UNKNOWN_MC for this family.
> >
> > Please try adding MV88E6XXX_FLAG_EDSA to
> > MV88E6XXX_FLAGS_FAMILY_6097. That is the better fix if it works.
>
> I was even wondering what EDSA means:) Thanks this solved the problem!
Plain DSA puts four bytes of header between the MAC source address and
the EtherType/Length.
EDSA puts in an 8 byte header, and includes an Ethertype value of
0xdada. Having that ethertype value makes it more obvious what is
going on. And if you have a recent version of tcpdump, it will decode
the header.
Andrew
next prev parent reply other threads:[~2016-11-23 17:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 10:39 [PATCH] net: dsa: mv88e6xxx: egress all frames Stefan Eichenberger
2016-11-22 15:03 ` Andrew Lunn
2016-11-22 18:37 ` Stefan Eichenberger
2016-11-22 19:02 ` Andrew Lunn
2016-11-22 22:15 ` Vivien Didelot
2016-11-23 9:56 ` Stefan Eichenberger
2016-11-23 12:00 ` Stefan Eichenberger
2016-11-23 15:59 ` Vivien Didelot
2016-11-23 16:50 ` Stefan Eichenberger
2016-11-23 16:54 ` [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097 Stefan Eichenberger
2016-11-23 16:59 ` Andrew Lunn
2016-11-23 17:11 ` [PATCH v3] net: dsa: mv88e6xxx: enable EDSA " Stefan Eichenberger
2016-11-23 17:13 ` Andrew Lunn
2016-11-23 17:14 ` [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets " Stefan Eichenberger
2016-11-23 17:32 ` Andrew Lunn
2016-11-23 17:49 ` Stefan Eichenberger
2016-11-23 17:40 ` Andrew Lunn [this message]
2016-11-23 17:52 ` Vivien Didelot
2016-11-23 18:01 ` Andrew Lunn
2016-11-23 18:18 ` Vivien Didelot
2016-11-23 16:58 ` [PATCH] net: dsa: mv88e6xxx: egress all frames Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123174040.GE8760@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=eichest@gmail$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stefan.eichenberger@netmodule$(echo .)com \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox