From: Arnaldo Carvalho de Melo <acme@kernel•org>
To: David Miller <davem@davemloft•net>
Cc: Eric Dumazet <eric.dumazet@gmail•com>,
Alexander Duyck <aduyck@mirantis•com>,
Andrey Konovalov <andreyknvl@google•com>,
Linux Networking Development Mailing List
<netdev@vger•kernel.org>
Subject: [PATCH 1/1] GSO: Reload iph after pskb_may_pull
Date: Mon, 28 Nov 2016 12:36:58 -0300 [thread overview]
Message-ID: <20161128153658.GB4778@kernel.org> (raw)
As it may get stale and lead to use after free.
Acked-by: Eric Dumazet <eric.dumazet@gmail•com>
Cc: Alexander Duyck <aduyck@mirantis•com>
Cc: Andrey Konovalov <andreyknvl@google•com>
Fixes: cbc53e08a793 ("GSO: Add GSO type for fixed IPv4 ID")
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat•com>
---
net/ipv4/af_inet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index 5ddf5cda07f4..215143246e4b 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -1233,7 +1233,7 @@ struct sk_buff *inet_gso_segment(struct sk_buff *skb,
fixedid = !!(skb_shinfo(skb)->gso_type & SKB_GSO_TCP_FIXEDID);
/* fixed ID is invalid if DF bit is not set */
- if (fixedid && !(iph->frag_off & htons(IP_DF)))
+ if (fixedid && !(ip_hdr(skb)->frag_off & htons(IP_DF)))
goto out;
}
--
2.9.3
next reply other threads:[~2016-11-28 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 15:36 Arnaldo Carvalho de Melo [this message]
2016-11-28 16:34 ` [PATCH 1/1] GSO: Reload iph after pskb_may_pull Alexander Duyck
2016-11-30 1:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128153658.GB4778@kernel.org \
--to=acme@kernel$(echo .)org \
--cc=aduyck@mirantis$(echo .)com \
--cc=andreyknvl@google$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox