public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Florian Westphal <fw@strlen•de>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: Florian Westphal <fw@strlen•de>, netdev@vger•kernel.org
Subject: Re: [PATCH net-next 2/2] tcp: allow to turn tcp timestamp randomization off
Date: Wed, 30 Nov 2016 01:21:11 +0100	[thread overview]
Message-ID: <20161130002111.GB6454@breakpoint.cc> (raw)
In-Reply-To: <1480442832.18162.148.camel@edumazet-glaptop3.roam.corp.google.com>

Eric Dumazet <eric.dumazet@gmail•com> wrote:
> On Tue, 2016-11-29 at 16:45 +0100, Florian Westphal wrote:
> > Eric says: "By looking at tcpdump, and TS val of xmit packets of multiple
> > flows, we can deduct the relative qdisc delays (think of fq pacing).
> > This should work even if we have one flow per remote peer."
> > 
> > Having random per flow (or host) offsets doesn't allow that anymore so add
> > a way to turn this off.
> > 
> > Suggested-by: Eric Dumazet <edumazet@google•com>
> > Signed-off-by: Florian Westphal <fw@strlen•de>
> > ---
> 
> Excellent, thanks !
> 
> Acked-by: Eric Dumazet <edumazet@google•com>

Thanks for the ack, I missed connect() side though so this doesn't work
for outgoing connections, sorry :-/

I will send a v2.

next prev parent reply	other threads:[~2016-11-30  0:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 15:45 [PATCH net-next 1/2] tcp: randomize tcp timestamp offsets for each connection Florian Westphal
2016-11-29 15:45 ` [PATCH net-next 2/2] tcp: allow to turn tcp timestamp randomization off Florian Westphal
2016-11-29 18:07   ` Eric Dumazet
2016-11-30  0:21     ` Florian Westphal [this message]
2016-11-29 18:06 ` [PATCH net-next 1/2] tcp: randomize tcp timestamp offsets for each connection Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161130002111.GB6454@breakpoint.cc \
    --to=fw@strlen$(echo .)de \
    --cc=eric.dumazet@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox