Subject: Re: [PATCH iproute2/net-next] ss: initialise variables outside of for loop

From: Stephen Hemminger <[email-masked]>
Date: Fri, 2 Dec 2016 14:18:17 -0800

On Fri,  2 Dec 2016 12:56:05 +0100
Simon Horman <[email-masked]> wrote:

> Initialise for loops outside of for loops. GCC flags this as being
> out of spec unless C99 or C11 mode is used.
> 
> With this change the entire tree appears to compile cleanly with -Wall.
> 
> $ gcc --version
> gcc (Debian 4.9.2-10) 4.9.2
> ...
> $ make
> ...
> ss.c: In function ‘unix_show_sock’:
> ss.c:3128:4: error: ‘for’ loop initial declarations are only allowed in C99 or C11 mode
> ...
> 
> Signed-off-by: Simon Horman <[email-masked]>

Applied.
Note, I used to have -Wall in Makefile but old GCC were broken and would give
aliasing warnings.