From: Andrew Lunn <andrew@lunn•ch>
To: Volodymyr Bendiuga <volodymyr.bendiuga@westermo•se>
Cc: vivien.didelot@savoirfairelinux•com, f.fainelli@gmail•com,
netdev@vger•kernel.org, volodymyr.bendiuga@gmail•com,
Jonas Johansson <jonas.johansson@westermo•se>
Subject: Re: [PATCH] net:dsa:mv88e6xxx: delete timer and cancel ppu_work
Date: Tue, 6 Dec 2016 15:22:26 +0100 [thread overview]
Message-ID: <20161206142226.GD26615@lunn.ch> (raw)
In-Reply-To: <1481029062-16668-1-git-send-email-volodymyr.bendiuga@westermo.se>
On Tue, Dec 06, 2016 at 01:57:42PM +0100, Volodymyr Bendiuga wrote:
> Signed-off-by: Jonas Johansson <jonas.johansson@westermo•se>
> Signed-off-by: Volodymyr Bendiuga <volodymyr.bendiuga@westermo•se>
> ---
> drivers/net/dsa/mv88e6xxx/chip.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
> index ca453f3..4212fb6 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -4528,8 +4528,11 @@ static int mv88e6xxx_probe(struct mdio_device *mdiodev)
> out_mdio:
> mv88e6xxx_mdio_unregister(chip);
> out_g2_irq:
> - if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_G2_INT) && chip->irq > 0)
> + if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_G2_INT) && chip->irq > 0) {
> mv88e6xxx_g2_irq_free(chip);
> + del_timer(&chip->ppu_timer);
> + cancel_work_sync(&chip->ppu_work);
> + }
Why do this here, inside this if statement?
Vivien has also just reworked the PPU code. Please take a look at his
patches and see if they fix the issue.
Thanks
Andrew
next parent reply other threads:[~2016-12-06 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1481029062-16668-1-git-send-email-volodymyr.bendiuga@westermo.se>
2016-12-06 14:22 ` Andrew Lunn [this message]
2016-12-07 10:38 ` [PATCH] net:dsa:mv88e6xxx: delete timer and cancel ppu_work Volodymyr Bendiuga
2016-12-07 13:14 ` Volodymyr Bendiuga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206142226.GD26615@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jonas.johansson@westermo$(echo .)se \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
--cc=volodymyr.bendiuga@gmail$(echo .)com \
--cc=volodymyr.bendiuga@westermo$(echo .)se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox