Subject: Re: [PATCH iproute2 -net-next] lwt: BPF support for LWT

From: Stephen Hemminger <[email-masked]>
Date: Mon, 12 Dec 2016 15:41:34 -0800

On Mon, 12 Dec 2016 01:14:35 +0100
Daniel Borkmann <[email-masked]> wrote:

> +
> +static int lwt_parse_bpf(struct rtattr *rta, size_t len, int *argcp, char ***argvp,
> +			 int attr, const enum bpf_prog_type bpf_type)

Please break long lines like this.

> +
> +	/* argv is currently the first unparsed argument,
> +	 * but the lwt_parse_encap() caller will move to the next,
> +	 * so step back */
> +	*argcp = argc + 1;

iproute2 uses kernel comment style. 

I went ahead and fixed these.