Subject: Re: [RFC v2 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) interface

From: Stephen Hemminger <[email-masked]>
Date: Thu, 15 Dec 2016 09:36:57 -0800

On Thu, 15 Dec 2016 00:53:49 -0800
"Vishwanathapura, Niranjana" <[email-masked]> wrote:

> On Wed, Dec 14, 2016 at 11:59:34PM -0800, Vishwanathapura, Niranjana wrote:
> >+
> >+static inline bool is_hfi_ibdev(struct ib_device *ibdev)
> >+{
> >+	return !memcmp(ibdev->name, "hfi", 3);
> >+}  
> 
> I am thinking of adding a device capability flag to indicate HFI VNIC capabilty 
> instead of relying on the device name as above to identify a hfi ib deice.
> Any comments? Probably it can be addressed by a separate patch later.
> 
> Niranjana
> 
> >  

Agreed. device name can change at anytime.