From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: "Vishwanathapura,
Niranjana"
<niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org,
ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org,
Sadanand Warrier
<sadanand.warrier-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org>,
Sudeep Dutt <sudeep.dutt-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org>,
Tanya K Jajodia
<tanya.k.jajodia-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org>,
Andrzej Kacprowski
<andrzej.kacprowski-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org>
Subject: Re: [RFC v2 03/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) netdev
Date: Thu, 15 Dec 2016 10:01:09 -0700 [thread overview]
Message-ID: <20161215170109.GC3264@obsidianresearch.com> (raw)
In-Reply-To: <1481788782-89964-4-git-send-email-niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Wed, Dec 14, 2016 at 11:59:35PM -0800, Vishwanathapura, Niranjana wrote:
> +/**
> + * union hfi_vnic_bypass_hdr - VNIC bypass header
> + * @slid: source lid
> + * @length: length of packet
> + * @becn: backward explicit congestion notification
> + * @dlid: destination lid
> + * @sc: service class
> + * @fecn: forward explicit congestion notification
> + * @l2: L2 type (2=16B)
> + * @lt: link transfer field
> + * @l4: L4 type
> + * @slid_high: upper 4 bits of source lid
> + * @dlid_high: upper 4 bits of destination lid
> + * @pkey: partition key
> + * @entropy: entropy
> + * @age: packet age
> + * @l4_hdr: L4 header
> + */
> +union hfi_vnic_bypass_hdr {
> + struct {
> + struct {
> + uint64_t slid : 20;
> + uint64_t length : 11;
> + uint64_t becn : 1;
> + uint64_t dlid : 20;
> + uint64_t sc : 5;
> + uint64_t rsvd : 3;
> + uint64_t fecn : 1;
> + uint64_t l2 : 2;
> + uint64_t lt : 1;
> + };
> + struct {
> + uint64_t l4 : 8;
> + uint64_t slid_high : 4;
> + uint64_t dlid_high : 4;
> + uint64_t pkey : 16;
> + uint64_t entropy : 16;
> + uint64_t age : 8;
> + uint64_t rsvd1 : 8;
> + };
> + struct {
> + uint32_t rsvd2 : 16;
> + uint32_t l4_hdr : 16;
> + };
> + } __packed;
> + u32 dw[5];
> +};
This isn't going to work on BE, please fix it.
> +/**
> + * struct __hfi_vesw_info - HFI vnic virtual switch info
> + */
> +struct __hfi_vesw_info {
> + u16 fabric_id;
> + u16 vesw_id;
> +
> + u8 rsvd0[6];
> + u16 def_port_mask;
> +
> + u8 rsvd1[2];
> + u16 pkey;
> +
> + u8 rsvd2[4];
> + u32 u_mcast_dlid;
> + u32 u_ucast_dlid[HFI_VESW_MAX_NUM_DEF_PORT];
> +
> + u8 rsvd3[44];
> + u16 eth_mtu[HFI_VNIC_MAX_NUM_PCP];
> + u16 eth_mtu_non_vlan;
> + u8 rsvd4[2];
> +} __packed;
This goes on the network too? Also looks like it has endian problems.
Ditto for all the __packed structures.
> +#define v_dbg(format, arg...) \
> + netdev_dbg(adapter->netdev, format, ## arg)
> +#define v_err(format, arg...) \
> + netdev_err(adapter->netdev, format, ## arg)
> +#define v_info(format, arg...) \
> + netdev_info(adapter->netdev, format, ## arg)
> +#define v_warn(format, arg...) \
> + netdev_warn(adapter->netdev, format, ## arg)
Relies on an 'adapter' local varable?? Ugly.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-12-15 17:01 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 7:59 [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC) Vishwanathapura, Niranjana
2016-12-15 7:59 ` [RFC v2 01/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) documentation Vishwanathapura, Niranjana
2016-12-15 7:59 ` [RFC v2 05/10] IB/hfi-vnic: VNIC statistics support Vishwanathapura, Niranjana
[not found] ` <1481788782-89964-1-git-send-email-niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-12-15 7:59 ` [RFC v2 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) interface Vishwanathapura, Niranjana
[not found] ` <1481788782-89964-3-git-send-email-niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-12-15 8:53 ` Vishwanathapura, Niranjana
[not found] ` <20161215085349.GA90068-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2016-12-15 8:56 ` Christoph Hellwig
2016-12-15 17:36 ` Stephen Hemminger
2016-12-15 7:59 ` [RFC v2 03/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) netdev Vishwanathapura, Niranjana
[not found] ` <1481788782-89964-4-git-send-email-niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-12-15 17:01 ` Jason Gunthorpe [this message]
2016-12-15 17:21 ` Hefty, Sean
2016-12-15 17:24 ` Jason Gunthorpe
2016-12-15 17:26 ` Christoph Hellwig
[not found] ` <20161215170109.GC3264-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-12-16 2:59 ` Vishwanathapura, Niranjana
2016-12-16 4:24 ` Jason Gunthorpe
[not found] ` <20161216042420.GB3797-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-12-19 6:43 ` Vishwanathapura, Niranjana
2016-12-15 7:59 ` [RFC v2 04/10] IB/hfi-vnic: VNIC Ethernet Management (EM) structure definitions Vishwanathapura, Niranjana
2016-12-15 7:59 ` [RFC v2 06/10] IB/hfi-vnic: VNIC MAC table support Vishwanathapura, Niranjana
2016-12-15 7:59 ` [RFC v2 07/10] IB/hfi-vnic: VNIC Ethernet Management Agent (VEMA) interface Vishwanathapura, Niranjana
2016-12-15 9:12 ` [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC) Leon Romanovsky
[not found] ` <20161215091226.GC811-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2016-12-15 14:52 ` ira.weiny
[not found] ` <20161215145212.GA29116-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2016-12-15 16:28 ` Doug Ledford
[not found] ` <380b05bf-a18e-1f20-7e8e-10b61f77dec7-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-12-15 17:07 ` Jason Gunthorpe
2016-12-15 18:19 ` Doug Ledford
[not found] ` <4e22bf29-2260-0768-ab17-9a8df6306f37-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-12-15 18:48 ` Jason Gunthorpe
[not found] ` <20161215184837.GA16552-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-12-16 1:24 ` ira.weiny
[not found] ` <20161216012404.GD3785-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2016-12-16 2:30 ` Vishwanathapura, Niranjana
2016-12-16 4:17 ` Jason Gunthorpe
2017-01-17 19:27 ` Vishwanathapura, Niranjana
[not found] ` <20170117192720.GA2833-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-01-18 5:43 ` Leon Romanovsky
2017-01-18 16:46 ` Jason Gunthorpe
[not found] ` <20161215170713.GD3264-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-12-16 2:47 ` Vishwanathapura, Niranjana
2017-01-09 7:51 ` Leon Romanovsky
[not found] ` <20170109075104.GV15685-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-01-10 3:39 ` Vishwanathapura, Niranjana
[not found] ` <20170110033954.GA53664-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-01-10 8:14 ` Leon Romanovsky
[not found] ` <20170110081402.GH7218-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-01-11 9:05 ` Vishwanathapura, Niranjana
2017-01-11 9:16 ` Leon Romanovsky
2016-12-15 7:59 ` [RFC v2 08/10] IB/hfi-vnic: VNIC Ethernet Management Agent (VEMA) function Vishwanathapura, Niranjana
2016-12-15 7:59 ` [RFC v2 09/10] IB/hfi1: Virtual Network Interface Controller (VNIC) support Vishwanathapura, Niranjana
2016-12-15 7:59 ` [RFC v2 10/10] IB/hfi1: VNIC SDMA support Vishwanathapura, Niranjana
2016-12-15 16:56 ` [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC) Jason Gunthorpe
[not found] ` <20161215165611.GB3264-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-12-16 4:14 ` Vishwanathapura, Niranjana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161215170109.GC3264@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=andrzej.kacprowski-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=sadanand.warrier-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=sudeep.dutt-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=tanya.k.jajodia-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox