From: Andrew Lunn <andrew@lunn•ch>
To: Volodymyr Bendiuga <volodymyr.bendiuga@gmail•com>
Cc: vivien.didelot@savoirfairelinux•com, f.fainelli@gmail•com,
netdev@vger•kernel.org, volodymyr.bendiuga@westermo•se
Subject: Re: [PATCH v2 net-next] net:mv88e6xxx: use g2 interrupt for 6097 chip
Date: Tue, 3 Jan 2017 17:28:15 +0100 [thread overview]
Message-ID: <20170103162815.GC32450@lunn.ch> (raw)
In-Reply-To: <1483456720-9929-1-git-send-email-volodymyr.bendiuga@gmail.com>
On Tue, Jan 03, 2017 at 04:18:40PM +0100, Volodymyr Bendiuga wrote:
> From: Volodymyr Bendiuga <volodymyr.bendiuga@westermo•se>
>
> This chip needs MV88E6XXX_FLAG_G2_INT
>
> Signed-off-by: Volodymyr Bendiuga <volodymyr.bendiuga@westermo•se>
> Reviewed-by: Andrew Lunn <andrew@lunn•ch>
> ---
> drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
> index af54bae..431e954 100644
> --- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
> +++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
> @@ -566,6 +566,7 @@ enum mv88e6xxx_cap {
> (MV88E6XXX_FLAG_G1_ATU_FID | \
> MV88E6XXX_FLAG_G1_VTU_FID | \
> MV88E6XXX_FLAG_GLOBAL2 | \
> + MV88E6XXX_FLAG_G2_INT | \
checkpatch is your friend:
$ ./scripts/checkpatch.pl volodymyr.bendiuga
ERROR: code indent should use tabs where possible
#76: FILE: drivers/net/dsa/mv88e6xxx/mv88e6xxx.h:569:
+ ^I MV88E6XXX_FLAG_G2_INT |^I\$
WARNING: please, no space before tabs
#76: FILE: drivers/net/dsa/mv88e6xxx/mv88e6xxx.h:569:
+ ^I MV88E6XXX_FLAG_G2_INT |^I\$
WARNING: please, no spaces at the start of a line
#76: FILE: drivers/net/dsa/mv88e6xxx/mv88e6xxx.h:569:
+ ^I MV88E6XXX_FLAG_G2_INT |^I\$
total: 1 errors, 2 warnings, 0 checks, 7 lines checked
Andrew
prev parent reply other threads:[~2017-01-03 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 15:18 [PATCH v2 net-next] net:mv88e6xxx: use g2 interrupt for 6097 chip Volodymyr Bendiuga
2017-01-03 16:18 ` David Miller
2017-01-03 16:28 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103162815.GC32450@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=f.fainelli@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
--cc=volodymyr.bendiuga@gmail$(echo .)com \
--cc=volodymyr.bendiuga@westermo$(echo .)se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox