Subject: Re: [PATCH iproute2] f_flower: don't set TCA_FLOWER_KEY_ETH_TYPE for "protocol all"

From: Stephen Hemminger <[email-masked]>
Date: Fri, 20 Jan 2017 09:34:45 -0800

On Thu, 19 Jan 2017 16:51:59 -0500
Benjamin LaHaise <[email-masked]> wrote:

> When using the tc filter flower, rules marked with "protocol all" do not
> actually match all packets.  This is due to a bug in f_flower.c that passes
> in ETH_P_ALL in the TCA_FLOWER_KEY_ETH_TYPE attribute when adding a rule.
> Fix this by omitting TCA_FLOWER_KEY_ETH_TYPE if the protocol is set to
> ETH_P_ALL.
>     
> Signed-off-by: Benjamin LaHaise <[email-masked]>
> Signed-off-by: Benjamin LaHaise <[email-masked]>

This looks good, but does not apply cleanly to either master or net-next branch
of current repository. Please rebase and resubmit.

It would be helpful to to use Fixes: tag for something which was broken by
a single previous commit.