From: Alexei Starovoitov <alexei.starovoitov@gmail•com>
To: Michael Chan <michael.chan@broadcom•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH net-next 00/10] bnxt_en: Add XDP support.
Date: Mon, 30 Jan 2017 20:47:47 -0800 [thread overview]
Message-ID: <20170131044745.GA8082@ast-mbp.thefacebook.com> (raw)
In-Reply-To: <1485827375-20421-1-git-send-email-michael.chan@broadcom.com>
On Mon, Jan 30, 2017 at 08:49:25PM -0500, Michael Chan wrote:
> The first 8 patches refactor the code (rx/tx code paths and ring logic)
> and add the basic infrastructure to support XDP. The 9th patch adds
> basic ndo_xdp to support XDP_DROP and XDP_PASS only. The 10th patch
> completes the series with XDP_TX.
Looks great.
Could you please share performance numbers ?
Also please add something like:
if (prog && prog->xdp_adjust_head) {
netdev_warn(dev, "Does not support bpf_xdp_adjust_head()\n");
return -EOPNOTSUPP;
}
unless you plan to add adjut_head support until net-next closes.
Note, it's must have for load balancer functionality.
next prev parent reply other threads:[~2017-01-31 4:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 1:49 [PATCH net-next 00/10] bnxt_en: Add XDP support Michael Chan
2017-01-31 1:49 ` [PATCH net-next 01/10] bnxt_en: Refactor rx SKB function Michael Chan
2017-01-31 4:26 ` Jakub Kicinski
2017-01-31 18:27 ` David Miller
2017-01-31 1:49 ` [PATCH net-next 02/10] bnxt_en: Add bp->rx_dir field for rx buffer DMA direction Michael Chan
2017-01-31 1:49 ` [PATCH net-next 03/10] bnxt_en: Add RX page mode support Michael Chan
2017-01-31 1:49 ` [PATCH net-next 04/10] bnxt_en: Use event bit map in RX path Michael Chan
2017-01-31 1:49 ` [PATCH net-next 05/10] bnxt_en: Centralize logic to reserve rings Michael Chan
2017-01-31 1:49 ` [PATCH net-next 06/10] bnxt_en: Add tx ring mapping logic Michael Chan
2017-01-31 1:49 ` [PATCH net-next 07/10] bnxt_en: Add a set of TX rings to support XDP Michael Chan
2017-01-31 1:49 ` [PATCH net-next 08/10] bnxt_en: Refactor tx completion path Michael Chan
2017-01-31 1:49 ` [PATCH net-next 09/10] bnxt_en: Add basic XDP support Michael Chan
2017-01-31 5:04 ` Jakub Kicinski
2017-01-31 7:33 ` Michael Chan
2017-01-31 1:49 ` [PATCH net-next 10/10] bnxt_en: Add support for XDP_TX action Michael Chan
2017-01-31 5:27 ` Jakub Kicinski
2017-01-31 7:19 ` Michael Chan
2017-01-31 4:47 ` Alexei Starovoitov [this message]
2017-01-31 5:13 ` [PATCH net-next 00/10] bnxt_en: Add XDP support Jakub Kicinski
2017-01-31 7:38 ` Michael Chan
-- strict thread matches above, loose matches on Subject: below --
2017-01-31 15:36 Andy Gospodarek
2017-02-01 5:33 ` Andy Gospodarek
2017-01-31 17:57 Alexei Starovoitov
2017-02-01 6:22 Alexei Starovoitov
2017-02-01 12:16 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131044745.GA8082@ast-mbp.thefacebook.com \
--to=alexei.starovoitov@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox