From: Ben Hutchings <ben@decadent•org.uk>
To: netdev@vger•kernel.org
Cc: linux-usb@vger•kernel.org
Subject: [PATCH net 4/4] catc: Use heap buffer for memory size test
Date: Sat, 4 Feb 2017 16:57:04 +0000 [thread overview]
Message-ID: <20170204165704.GY3442@decadent.org.uk> (raw)
In-Reply-To: <20170204165451.GU3442@decadent.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1893 bytes --]
Allocating USB buffers on the stack is not portable, and no longer
works on x86_64 (with VMAP_STACK enabled as per default).
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Ben Hutchings <ben@decadent•org.uk>
---
drivers/net/usb/catc.c | 25 ++++++++++++++++++-------
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c
index 985909eab72c..0acc9b640419 100644
--- a/drivers/net/usb/catc.c
+++ b/drivers/net/usb/catc.c
@@ -776,7 +776,7 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id
struct net_device *netdev;
struct catc *catc;
u8 broadcast[ETH_ALEN];
- int i, pktsz, ret;
+ int pktsz, ret;
if (usb_set_interface(usbdev,
intf->altsetting->desc.bInterfaceNumber, 1)) {
@@ -840,15 +840,24 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id
catc->irq_buf, 2, catc_irq_done, catc, 1);
if (!catc->is_f5u011) {
+ u32 *buf;
+ int i;
+
dev_dbg(dev, "Checking memory size\n");
- i = 0x12345678;
- catc_write_mem(catc, 0x7a80, &i, 4);
- i = 0x87654321;
- catc_write_mem(catc, 0xfa80, &i, 4);
- catc_read_mem(catc, 0x7a80, &i, 4);
+ buf = kmalloc(4, GFP_KERNEL);
+ if (!buf) {
+ ret = -ENOMEM;
+ goto fail_free;
+ }
+
+ *buf = 0x12345678;
+ catc_write_mem(catc, 0x7a80, buf, 4);
+ *buf = 0x87654321;
+ catc_write_mem(catc, 0xfa80, buf, 4);
+ catc_read_mem(catc, 0x7a80, buf, 4);
- switch (i) {
+ switch (*buf) {
case 0x12345678:
catc_set_reg(catc, TxBufCount, 8);
catc_set_reg(catc, RxBufCount, 32);
@@ -863,6 +872,8 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id
dev_dbg(dev, "32k Memory\n");
break;
}
+
+ kfree(buf);
dev_dbg(dev, "Getting MAC from SEEROM.\n");
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2017-02-04 16:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-04 16:54 [PATCH net 0/4] Fix on-stack USB buffers Ben Hutchings
2017-02-04 16:56 ` [PATCH net 1/4] pegasus: Use heap buffers for all register access Ben Hutchings
2017-02-05 0:30 ` Greg KH
2017-02-06 8:14 ` Petko Manolov
2017-02-06 8:28 ` Greg KH
2017-02-06 12:51 ` Petko Manolov
2017-02-06 13:21 ` Johan Hovold
2017-02-06 13:32 ` Johan Hovold
2017-02-06 13:46 ` Johan Hovold
2017-02-07 10:24 ` Petko Manolov
2017-02-07 10:45 ` Greg KH
[not found] ` <20170207104506.GB32583-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-02-07 12:50 ` Petko Manolov
2017-02-06 13:30 ` David Laight
2017-02-07 18:32 ` Steve Calfee
2017-02-08 7:57 ` Petko Manolov
2017-02-04 16:56 ` [PATCH net 2/4] rtl8150: " Ben Hutchings
2017-02-06 8:10 ` Petko Manolov
[not found] ` <20170204165631.GW3442-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
2017-02-06 16:09 ` David Laight
2017-02-06 16:25 ` Ben Hutchings
2017-02-07 10:34 ` Petko Manolov
2017-02-07 10:51 ` Greg KH
2017-02-07 11:56 ` David Laight
[not found] ` <063D6719AE5E284EB5DD2968C1650D6DB027DB75-VkEWCZq2GCInGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2017-02-07 12:42 ` 'Greg KH'
2017-02-07 12:53 ` Petko Manolov
2017-02-07 13:01 ` Greg KH
2017-02-07 13:20 ` Petko Manolov
2017-02-07 14:14 ` David Laight
2017-02-07 14:52 ` Petko Manolov
[not found] ` <20170204165451.GU3442-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
2017-02-04 16:56 ` [PATCH net 3/4] catc: Combine failure cleanup code in catc_probe() Ben Hutchings
2017-02-04 16:57 ` Ben Hutchings [this message]
2017-02-07 15:07 ` [PATCH net 0/4] Fix on-stack USB buffers David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170204165704.GY3442@decadent.org.uk \
--to=ben@decadent$(echo .)org.uk \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox