From: Ido Schimmel <idosch@idosch•org>
To: Marcus Huewe <suse-tux@gmx•de>
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH net] net: neigh: Fix netevent NETEVENT_DELAY_PROBE_TIME_UPDATE notification
Date: Wed, 15 Feb 2017 08:59:25 +0200 [thread overview]
Message-ID: <20170215065925.GA11243@splinter.mtl.com> (raw)
In-Reply-To: <20170215000036.qzzglyaasqfy7vsn@linux.fritz.box>
On Wed, Feb 15, 2017 at 01:00:36AM +0100, Marcus Huewe wrote:
> When setting a neigh related sysctl parameter, we always send a
> NETEVENT_DELAY_PROBE_TIME_UPDATE netevent. For instance, when
> executing
>
> sysctl net.ipv6.neigh.wlp3s0.retrans_time_ms=2000
>
> a NETEVENT_DELAY_PROBE_TIME_UPDATE netevent is generated.
>
> This is caused by commit 2a4501ae18b5 ("neigh: Send a
> notification when DELAY_PROBE_TIME changes"). According to the
> commit's description, it was intended to generate such an event
> when setting the "delay_first_probe_time" sysctl parameter.
>
> In order to fix this, only generate this event when actually
> setting the "delay_first_probe_time" sysctl parameter. This fix
> should not have any unintended side-effects, because all but one
> registered netevent callbacks check for other netevent event
> types (the registered callbacks were obtained by grepping for
> "register_netevent_notifier"). The only callback that uses the
> NETEVENT_DELAY_PROBE_TIME_UPDATE event is
> mlxsw_sp_router_netevent_event() (in
> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c): in case
> of this event, it only accesses the DELAY_PROBE_TIME of the
> passed neigh_parms.
>
> Signed-off-by: Marcus Huewe <suse-tux@gmx•de>
Fixes: 2a4501ae18b5 ("neigh: Send a notification when DELAY_PROBE_TIME changes")
Reviewed-by: Ido Schimmel <idosch@mellanox•com>
Next time, please Cc the author of the commit you're referring to in
your patch.
Thanks!
next prev parent reply other threads:[~2017-02-15 6:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 0:00 [PATCH net] net: neigh: Fix netevent NETEVENT_DELAY_PROBE_TIME_UPDATE notification Marcus Huewe
2017-02-15 6:59 ` Ido Schimmel [this message]
2017-02-15 17:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215065925.GA11243@splinter.mtl.com \
--to=idosch@idosch$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=suse-tux@gmx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox