Subject: Re: [RFC v2 00/20] Replace PCI pool by DMA pool API

From: Peter Senna Tschudin <[email-masked]>
Date: Sat, 18 Feb 2017 19:46:59 +0100

On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote:

Tested all patches by compilation and checkpatch. All of them compile
fine, but patches 11 and 12 need some fixes. You can resend as
PATCH instead of RFC.

> The current PCI pool API are simple macro functions direct expanded to
> the appropriated dma pool functions. The prototypes are almost the same
> and semantically, they are very similar. I propose to use the DMA pool
> API directly and get rid of the old API.
> 
> This set of patches, replaces the old API by the dma pool API, adds
> support to warn about this old API in checkpath.pl and remove the
> defines.
> 
> Changes in v2:
> - Introduced patch 18/20
> - Fixed cosmetic changes: spaces before brace, live over 80 characters
> - Removed some of the check for NULL pointers before calling dma_pool_destroy
> - Improved the regexp in checkpatch for pci_pool, thanks to Joe Perches
> - Added Tested-by and Acked-by tags
> 
> Romain Perier (20):
>   block: DAC960: Replace PCI pool old API
>   dmaengine: pch_dma: Replace PCI pool old API
>   IB/mthca: Replace PCI pool old API
>   net: e100: Replace PCI pool old API
>   mlx4: Replace PCI pool old API
>   mlx5: Replace PCI pool old API
>   wireless: ipw2200: Replace PCI pool old API
>   scsi: be2iscsi: Replace PCI pool old API
>   scsi: csiostor: Replace PCI pool old API
>   scsi: lpfc: Replace PCI pool old API
>   scsi: megaraid: Replace PCI pool old API
>   scsi: mpt3sas: Replace PCI pool old API
>   scsi: mvsas: Replace PCI pool old API
>   scsi: pmcraid: Replace PCI pool old API
>   usb: gadget: amd5536udc: Replace PCI pool old API
>   usb: gadget: net2280: Replace PCI pool old API
>   usb: gadget: pch_udc: Replace PCI pool old API
>   usb: host: Remove remaining pci_pool in comments
>   PCI: Remove PCI pool macro functions
>   checkpatch: warn for use of old PCI pool API
> 
>  drivers/block/DAC960.c                        | 36 ++++++-------
>  drivers/block/DAC960.h                        |  4 +-
>  drivers/dma/pch_dma.c                         | 12 ++---
>  drivers/infiniband/hw/mthca/mthca_av.c        | 10 ++--
>  drivers/infiniband/hw/mthca/mthca_cmd.c       |  8 +--
>  drivers/infiniband/hw/mthca/mthca_dev.h       |  4 +-
>  drivers/net/ethernet/intel/e100.c             | 12 ++---
>  drivers/net/ethernet/mellanox/mlx4/cmd.c      | 10 ++--
>  drivers/net/ethernet/mellanox/mlx4/mlx4.h     |  2 +-
>  drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 11 ++--
>  drivers/net/wireless/intel/ipw2x00/ipw2200.c  | 13 ++---
>  drivers/scsi/be2iscsi/be_iscsi.c              |  6 +--
>  drivers/scsi/be2iscsi/be_main.c               |  6 +--
>  drivers/scsi/be2iscsi/be_main.h               |  2 +-
>  drivers/scsi/csiostor/csio_hw.h               |  2 +-
>  drivers/scsi/csiostor/csio_init.c             | 11 ++--
>  drivers/scsi/csiostor/csio_scsi.c             |  6 +--
>  drivers/scsi/lpfc/lpfc.h                      | 10 ++--
>  drivers/scsi/lpfc/lpfc_init.c                 |  6 +--
>  drivers/scsi/lpfc/lpfc_mem.c                  | 73 +++++++++++++--------------
>  drivers/scsi/lpfc/lpfc_scsi.c                 | 12 ++---
>  drivers/scsi/megaraid/megaraid_mbox.c         | 30 +++++------
>  drivers/scsi/megaraid/megaraid_mm.c           | 29 ++++++-----
>  drivers/scsi/megaraid/megaraid_sas_base.c     | 25 ++++-----
>  drivers/scsi/megaraid/megaraid_sas_fusion.c   | 51 ++++++++++---------
>  drivers/scsi/mpt3sas/mpt3sas_base.c           | 73 +++++++++++++--------------
>  drivers/scsi/mvsas/mv_init.c                  |  6 +--
>  drivers/scsi/mvsas/mv_sas.c                   |  6 +--
>  drivers/scsi/pmcraid.c                        | 10 ++--
>  drivers/scsi/pmcraid.h                        |  2 +-
>  drivers/usb/gadget/udc/amd5536udc.c           |  8 +--
>  drivers/usb/gadget/udc/amd5536udc.h           |  4 +-
>  drivers/usb/gadget/udc/net2280.c              | 12 ++---
>  drivers/usb/gadget/udc/net2280.h              |  2 +-
>  drivers/usb/gadget/udc/pch_udc.c              | 31 ++++++------
>  drivers/usb/host/ehci-hcd.c                   |  2 +-
>  drivers/usb/host/fotg210-hcd.c                |  2 +-
>  drivers/usb/host/oxu210hp-hcd.c               |  2 +-
>  include/linux/mlx5/driver.h                   |  2 +-
>  include/linux/pci.h                           |  9 ----
>  scripts/checkpatch.pl                         |  9 +++-
>  41 files changed, 284 insertions(+), 287 deletions(-)
> 
> -- 
> 2.9.3
>