From: Stephen Hemminger <stephen@networkplumber•org>
To: Roopa Prabhu <roopa@cumulusnetworks•com>
Cc: David Miller <davem@davemloft•net>,
Nikolay Aleksandrov <nikolay@cumulusnetworks•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
David Ahern <dsa@cumulusnetworks•com>,
jkbs@redhat•com, Eric Dumazet <edumazet@google•com>,
Peter Christensen <pch@ordbogen•com>
Subject: Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice
Date: Tue, 14 Mar 2017 16:27:15 -0700 [thread overview]
Message-ID: <20170314162715.141f1d4b@xeon-e3> (raw)
In-Reply-To: <CAJieiUgQpOidyE-OH73QQpMcQnzEgd+9bGPOKA-yAaFtb3fcwQ@mail.gmail.com>
On Tue, 14 Mar 2017 15:38:40 -0700
Roopa Prabhu <roopa@cumulusnetworks•com> wrote:
> >> >> > That's what my initial version did, but this was discussed during NetConf in Seville
> >> >> > and it was decided that it's best to make a global sysctl, thus the change.
> >> >>
> >> >> Correct, we discussed this, and we all agreed to only have a sysctl for now.
> >> >
> >> > Why? If you are going to have private discussions please post the rationale
> >> > in public.
> >>
> >> Stephen, is there any reason to have a per ecmp route multipath algo
> >> selection ?.
> >> All platforms have a global multipath selection algo. I also don't see
> >> routing daemons ready or willing to specify a per ecmp route multipath
> >> selection algo attribute.
> >
> > There is no compelling reason to make the attribute per route. But the
> > issue is more that configuration through sysctl's is problematic. It doesn't
> > fit into the standard API paradigm. Sysctl's are like routing patches not
> > part of the real CLI. Trying to trap sysctl's for things like switchedev
> > offload is particularly problematic. I can see the case for either way,
> > and don't have a fixed opinion.
>
> ok. understand the switchdev offload part. It was that way in the past...but
> today you can listen to sysctl updates on the netconf netlink channel.
> it works pretty well.
Is there another patch to add the NETCONFA_ECMP support?
next prev parent reply other threads:[~2017-03-14 23:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 14:59 [PATCH net-next] net: ipv4: add support for ECMP hash policy choice Nikolay Aleksandrov
2017-03-06 16:24 ` David Ahern
2017-03-06 16:52 ` Nikolay Aleksandrov
2017-03-07 6:16 ` Roopa Prabhu
2017-03-07 11:01 ` [PATCH net-next v2] " Nikolay Aleksandrov
2017-03-08 12:05 ` Jakub Sitnicki
2017-03-08 12:43 ` Nikolay Aleksandrov
2017-03-08 16:00 ` Jakub Sitnicki
2017-03-13 2:23 ` David Miller
2017-03-14 15:36 ` [PATCH net-next v3] " Nikolay Aleksandrov
2017-03-14 15:55 ` Stephen Hemminger
2017-03-14 15:58 ` Nikolay Aleksandrov
2017-03-14 18:48 ` David Miller
2017-03-14 20:25 ` Stephen Hemminger
2017-03-14 21:10 ` Roopa Prabhu
2017-03-14 21:42 ` Stephen Hemminger
2017-03-14 22:38 ` Roopa Prabhu
2017-03-14 23:27 ` Stephen Hemminger [this message]
2017-03-14 23:45 ` David Ahern
2017-03-15 9:17 ` Nicolas Dichtel
2017-03-15 10:46 ` Nikolay Aleksandrov
2017-03-15 11:18 ` Nicolas Dichtel
2017-03-15 11:27 ` Nikolay Aleksandrov
2017-03-15 15:01 ` David Ahern
2017-03-15 15:20 ` Stephen Hemminger
2017-03-15 0:24 ` David Miller
2017-03-15 2:30 ` Tom Herbert
2017-03-17 3:36 ` David Miller
2017-03-14 18:55 ` Nikolay Aleksandrov
2017-03-15 11:32 ` Jakub Sitnicki
2017-03-15 12:10 ` Nikolay Aleksandrov
2017-03-16 13:28 ` [PATCH net-next v4] " Nikolay Aleksandrov
2017-03-16 16:41 ` Stephen Hemminger
2017-03-16 16:49 ` Nikolay Aleksandrov
2017-03-17 10:06 ` Nikolay Aleksandrov
2017-03-21 22:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314162715.141f1d4b@xeon-e3 \
--to=stephen@networkplumber$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dsa@cumulusnetworks$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=jkbs@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@cumulusnetworks$(echo .)com \
--cc=pch@ordbogen$(echo .)com \
--cc=roopa@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox