From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public•gmane.org>
To: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public•gmane.org>
Cc: benve-FYB4Gu1CFyUAvxtiuMwx3w@public•gmane.org,
dgoodell-FYB4Gu1CFyUAvxtiuMwx3w@public•gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org,
monis-VPRAkNaXOzVWk0Htik3J/w@public•gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH v4] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function
Date: Tue, 14 Mar 2017 19:58:43 +0200 [thread overview]
Message-ID: <20170314175843.GY2079@mtr-leonro.local> (raw)
In-Reply-To: <1489500117-7937-1-git-send-email-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]
On Tue, Mar 14, 2017 at 04:01:57PM +0200, Yuval Shaia wrote:
> This logic seems to be duplicated in (at least) three separate files.
> Move it to one place so code can be re-use.
>
> Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public•gmane.org>
> ---
> v0 -> v1:
> * Add missing #include
> * Rename to genaddrconf_ifid_eui48
> v1 -> v2:
> * Reset eui[0] to default if dev_id is used
> v2 -> v3:
> * Add helper function to avoid re-setting eui[0] to default if
> dev_id is used
> v3 -> v4:
> * Remove RXE wrappers
> * Remove addrconf_addr_eui48_xor and do the eui[0] ^= 2 in the
> basic implementation
> ---
> drivers/infiniband/hw/usnic/usnic_common_util.h | 11 +++-------
> drivers/infiniband/sw/rxe/rxe.c | 4 +++-
> drivers/infiniband/sw/rxe/rxe_loc.h | 2 --
> drivers/infiniband/sw/rxe/rxe_net.c | 28 -------------------------
> drivers/infiniband/sw/rxe/rxe_verbs.c | 4 +++-
> include/net/addrconf.h | 22 +++++++++++++++----
> 6 files changed, 27 insertions(+), 44 deletions(-)
>
Thanks, Yuval.
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public•gmane.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-03-14 17:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 14:01 [PATCH v4] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function Yuval Shaia
[not found] ` <1489500117-7937-1-git-send-email-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-03-14 17:58 ` Leon Romanovsky [this message]
[not found] ` <20170314175843.GY2079-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-04-24 15:46 ` Yuval Shaia
2017-04-25 18:21 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314175843.GY2079@mtr-leonro.local \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public$(echo .)gmane.org \
--cc=benve-FYB4Gu1CFyUAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=dgoodell-FYB4Gu1CFyUAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=monis-VPRAkNaXOzVWk0Htik3J/w@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox