From: Andrew Lunn <andrew@lunn•ch>
To: Joao Pinto <Joao.Pinto@synopsys•com>
Cc: Thierry Reding <thierry.reding@gmail•com>,
davem@davemloft•net, peppe.cavallaro@st•com,
alexandre.torgue@st•com, f.fainelli@gmail•com,
netdev@vger•kernel.org
Subject: Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers
Date: Fri, 24 Mar 2017 08:42:55 +0100 [thread overview]
Message-ID: <20170324074255.GB16730@lunn.ch> (raw)
In-Reply-To: <2ec8451b-4d12-d7ea-a2ce-4f1add382df4@synopsys.com>
On Thu, Mar 23, 2017 at 05:27:08PM +0000, Joao Pinto wrote:
> Yes, you are correct. It should be priv->plat->tx_queues_to_use instead of "u32
> tx_count = priv->dma_cap.number_tx_queues;"... sorry for that, but in my setup
> is the same value. Could you please make a patch for it?
Hi Joao
As the new maintainer, don't you think you should be testing on
multiple systems? There are SoC vendor reference design boards you can
buy, and set up a test farm. You can then ensure your new features
don't break stuff, or add performance regressions.
Andrew
next prev parent reply other threads:[~2017-03-24 7:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 16:11 [PATCH v2 net-next 0/3] net: stmmac: adding multiple buffers and routing Joao Pinto
2017-03-17 16:11 ` [PATCH v2 net-next 1/3] net: stmmac: enable multiple buffers Joao Pinto
2017-03-23 17:17 ` [v2,net-next,1/3] " Thierry Reding
2017-03-23 17:27 ` Joao Pinto
2017-03-23 18:10 ` Thierry Reding
2017-03-24 14:09 ` Corentin Labbe
2017-03-24 14:59 ` Joao Pinto
2017-03-24 15:02 ` Fwd: " Joao Pinto
2017-03-24 17:17 ` David Miller
2017-03-24 17:19 ` Joao Pinto
2017-03-24 7:42 ` Andrew Lunn [this message]
2017-03-24 10:47 ` Joao Pinto
2017-03-24 11:17 ` Andrew Lunn
2017-03-24 11:21 ` Joao Pinto
2017-03-24 17:05 ` David Miller
2017-03-24 17:09 ` Joao Pinto
2017-03-27 9:28 ` Alexandre Torgue
2017-03-27 9:34 ` Joao Pinto
2017-03-17 16:11 ` [PATCH v2 net-next 2/3] net: stmmac: TX and RX queue priority configuration Joao Pinto
2017-03-17 16:11 ` [PATCH v2 net-next 3/3] net: stmmac: RX queue routing configuration Joao Pinto
2017-03-22 0:24 ` [PATCH v2 net-next 0/3] net: stmmac: adding multiple buffers and routing David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324074255.GB16730@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=Joao.Pinto@synopsys$(echo .)com \
--cc=alexandre.torgue@st$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox