Subject: Re: [PATCH nf v3 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register

From: Pablo Neira Ayuso <[email-masked]>
Date: Fri, 24 Mar 2017 13:21:30 +0100

On Tue, Mar 21, 2017 at 08:22:29AM +0800, [email-masked] wrote:
> From: Gao Feng <[email-masked]>
> 
> In the commit 93557f53e1fb ("netfilter: nf_conntrack: nf_conntrack snmp
> helper"), the snmp_helper is replaced by nf_nat_snmp_hook. So the
> snmp_helper is never registered. But it still tries to unregister the
> snmp_helper, it could cause the panic.

This patch looks correct to me.

But probably for some reason I don't manage to trigger, how do you
reproduce this?