public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: "John W. Linville" <linville@tuxdriver•com>
To: Jakub Kicinski <kubakici@wp•pl>
Cc: Gal Pressman <galp@mellanox•com>,
	netdev@vger•kernel.org, Eyal Perry <eyalpe@mellanox•com>
Subject: Re: [PATCH ethtool] ethtool: Support for configurable RSS hash function
Date: Mon, 27 Mar 2017 14:02:06 -0400	[thread overview]
Message-ID: <20170327180203.GB29050@tuxdriver.com> (raw)
In-Reply-To: <20170325145047.6a5a7967@cakuba.netronome.com>

On Sat, Mar 25, 2017 at 02:50:47PM -0700, Jakub Kicinski wrote:
> On Wed,  8 Mar 2017 16:03:51 +0200, Gal Pressman wrote:
> > This ethtool patch adds support to set and get the current RSS hash
> > function for the device through the new hfunc mask field in the
> > ethtool_rxfh struct. Kernel supported hash function names are queried
> > with ETHTOOL_GSTRINGS - each string is corresponding with a bit in hfunc
> > mask according to its index in the string-set.
> > 
> > Signed-off-by: Eyal Perry <eyalpe@mellanox•com>
> > Signed-off-by: Gal Pressman <galp@mellanox•com>
> > Reviewed-by: Saeed Mahameed <saeedm@mellanox•com>
> 
> Hi John,
> 
> It seems you have applied both my earlier patch with get support and
> this:
> 
> adbaa18b9bc1 ("ethtool: Support for configurable RSS hash function")
> b932835d2302 ("ethtool: print hash function with ethtool -x|--show-rxfh-indir")
> 
> Now we print the RSS function twice:
> 
> RX flow hash indirection table for em4 with 4 RX ring(s):
>     0:      [...]
> RSS hash function: toeplitz  <--- from my adbaa18b9bc1
> RSS hash key:
> Operation not supported
> RSS hash function:           <--- from this patch
>     toeplitz: on
>     xor: off
>     crc32: off
> 
> Reverting my patch is probably the easiest way forward, although I find
> it more concise and easier to parse in test scripts :)

Thanks for pointing-out this issue! I apologize for my own confusion.

As you suggest, I will be reverting your patch.

Thanks,

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver•com			might be all we have.  Be ready.

next prev parent reply	other threads:[~2017-03-27 18:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08 14:03 [PATCH ethtool] ethtool: Support for configurable RSS hash function Gal Pressman
2017-03-25 21:50 ` Jakub Kicinski
2017-03-26 10:50   ` Gal Pressman
2017-03-27 18:02   ` John W. Linville [this message]
2017-03-29 11:56     ` Gal Pressman
2017-03-29 14:49       ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170327180203.GB29050@tuxdriver.com \
    --to=linville@tuxdriver$(echo .)com \
    --cc=eyalpe@mellanox$(echo .)com \
    --cc=galp@mellanox$(echo .)com \
    --cc=kubakici@wp$(echo .)pl \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox