From: Andrew Lunn <andrew@lunn•ch>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: netdev@vger•kernel.org
Subject: Re: genphy_read_status() vs. 1000bT Pause capability
Date: Tue, 28 Mar 2017 03:09:40 +0200 [thread overview]
Message-ID: <20170328010940.GG25549@lunn.ch> (raw)
In-Reply-To: <1490662190.3177.91.camel@kernel.crashing.org>
On Tue, Mar 28, 2017 at 11:49:50AM +1100, Benjamin Herrenschmidt wrote:
> Hi !
>
> I noticed that flow control isn't being enabled on a system I'm
> working on by default. I've tracked it down to two things:
>
> - The realtec.c PHY driver doesn't have Pause or Asym_Pause in
> its exposed capabilities. This is in part because PHY_GBIT_FEATURES
> does not include SUPPORTED_Pause and SUPPORTED_Asym_Pause. Is there
> a specific reason for that ?
Hi Ben
It is worth reading Documentation/networking/phy.txt
The MAC should set SUPPORTED_Pause and SUPPORTED_Asym_Pause if the MAC
supports these features. The PHY will then negotiate them.
Andrew
next prev parent reply other threads:[~2017-03-28 1:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 0:49 genphy_read_status() vs. 1000bT Pause capability Benjamin Herrenschmidt
2017-03-28 1:09 ` Andrew Lunn [this message]
2017-03-28 2:28 ` Benjamin Herrenschmidt
2017-03-28 2:55 ` Benjamin Herrenschmidt
2017-03-28 4:14 ` Florian Fainelli
[not found] ` <20170328041405.045FEB206B@b01ledav03.gho.pok.ibm.com>
2017-03-28 5:17 ` Benjamin Herrenschmidt
2017-03-28 5:19 ` Benjamin Herrenschmidt
2017-03-28 9:42 ` Russell King - ARM Linux
2017-03-28 11:11 ` Benjamin Herrenschmidt
2017-03-28 11:31 ` Russell King - ARM Linux
2017-03-28 20:32 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328010940.GG25549@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=benh@kernel$(echo .)crashing.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox