From: Ido Schimmel <idosch@idosch•org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
Cc: "Peter V. Saveliev" <peter@svinota•eu>,
netdev@vger•kernel.org, Ivan Vecera <ivecera@redhat•com>
Subject: Re: [BUG] kernel oops during bridge creation
Date: Thu, 6 Apr 2017 23:44:52 +0300 [thread overview]
Message-ID: <20170406204452.GA24938@splinter> (raw)
In-Reply-To: <adc7b0d6-68b9-6649-73fc-f5e82812f4a6@cumulusnetworks.com>
On Thu, Apr 06, 2017 at 11:26:06PM +0300, Nikolay Aleksandrov wrote:
> Actually making br_vlan_init() idempotent might work, keep the code as-is just init the
> the vlans before the changelink() in newlink(), then the second vlan_init() inside would
> be a no-op, but it will work for the old ioctl and wouldn't require too much change.
> On the downside it will be ugly.
Yep, that can work. I'll try that tomorrow morning and let you know.
Thanks Nik!
next prev parent reply other threads:[~2017-04-06 20:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 18:19 [BUG] kernel oops during bridge creation Peter V. Saveliev
2017-04-06 18:58 ` Ido Schimmel
2017-04-06 20:26 ` Nikolay Aleksandrov
2017-04-06 20:44 ` Ido Schimmel [this message]
2017-04-07 8:36 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406204452.GA24938@splinter \
--to=idosch@idosch$(echo .)org \
--cc=ivecera@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@cumulusnetworks$(echo .)com \
--cc=peter@svinota$(echo .)eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox