From: Pablo Neira Ayuso <pablo@netfilter•org>
To: Arushi Singhal <arushisinghal19971997@gmail•com>
Cc: Jozsef Kadlecsik <kadlec@blackhole•kfki.hu>,
"David S. Miller" <davem@davemloft•net>,
Alexey Kuznetsov <kuznet@ms2•inr.ac.ru>,
James Morris <jmorris@namei•org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6•org>,
Patrick McHardy <kaber@trash•net>,
netfilter-devel@vger•kernel.org, coreteam@netfilter•org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
outreachy-kernel@googlegroups•com
Subject: Re: [Outreachy kernel] [PATCH] net: ipv6: netfilter: Format block comments.
Date: Fri, 7 Apr 2017 18:15:07 +0200 [thread overview]
Message-ID: <20170407161507.GA9367@salvia> (raw)
In-Reply-To: <20170329083943.GA23844@arushi-HP-Pavilion-Notebook>
On Wed, Mar 29, 2017 at 02:09:43PM +0530, Arushi Singhal wrote:
> Fix checkpatch warnings:
> WARNING: Block comments use a trailing */ on a separate line
> WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail•com>
> ---
> net/ipv6/netfilter/ip6_tables.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c
> index b8cb61c27aa1..ac69ce3bfa1e 100644
> --- a/net/ipv6/netfilter/ip6_tables.c
> +++ b/net/ipv6/netfilter/ip6_tables.c
> @@ -51,14 +51,14 @@ void *ip6t_alloc_initial_table(const struct xt_table *info)
> }
> EXPORT_SYMBOL_GPL(ip6t_alloc_initial_table);
>
> -/*
> - We keep a set of rules for each CPU, so we can avoid write-locking
> - them in the softirq when updating the counters and therefore
> - only need to read-lock in the softirq; doing a write_lock_bh() in user
> - context stops packets coming through and allows user context to read
> - the counters or update the rules.
> -
> - Hence the start of any table is given by get_table() below. */
> +/* We keep a set of rules for each CPU, so we can avoid write-locking
> + * them in the softirq when updating the counters and therefore
> + * only need to read-lock in the softirq; doing a write_lock_bh() in user
> + * context stops packets coming through and allows user context to read
> + * the counters or update the rules.
> + *
> + * Hence the start of any table is given by get_table() below.
> + */
This comment is obsolete and should go.
We have no set of rules per CPU anymore.
prev parent reply other threads:[~2017-04-07 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 8:39 [PATCH] net: ipv6: netfilter: Format block comments Arushi Singhal
2017-04-07 16:15 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407161507.GA9367@salvia \
--to=pablo@netfilter$(echo .)org \
--cc=arushisinghal19971997@gmail$(echo .)com \
--cc=coreteam@netfilter$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=jmorris@namei$(echo .)org \
--cc=kaber@trash$(echo .)net \
--cc=kadlec@blackhole$(echo .)kfki.hu \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=outreachy-kernel@googlegroups$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox