Subject: Re: [PATCH iproute2 net-next 1/3] ip: add ip sr command to control SR-IPv6 internal structures

From: Stephen Hemminger <[email-masked]>
Date: Fri, 14 Apr 2017 15:45:31 -0700

On Fri, 14 Apr 2017 14:36:21 +0200
David Lebrun <[email-masked]> wrote:

> +static struct {
> +	int cmd;
Why not unsigned? you only assign positive values
> +	struct in6_addr addr;
> +	__u32 keyid;
> +	char *pass;
Why not const char *? or do you free the value on exit?
> +	__u8 alg_id;
> +} opts;
> +