Subject: Re: [PATCH][net-next] esp6: fix incorrect null pointer check on xo

From: Steffen Klassert <[email-masked]>
Date: Wed, 19 Apr 2017 07:20:49 +0200

On Tue, Apr 18, 2017 at 01:12:53PM -0400, David Miller wrote:
> From: Colin King <[email-masked]>
> Date: Tue, 18 Apr 2017 15:06:53 +0100
> 
> Trimming the CC: list down to something that actually makes
> sense.
> 
> > From: Colin Ian King <[email-masked]>
> > 
> > The check for xo being null is incorrect, currently it is checking
> > for non-null, it should be checking for null.
> > 
> > Detected with CoverityScan, CID#1429349 ("Dereference after null check")
> > 
> > Signed-off-by: Colin Ian King <[email-masked]>

I've added

Fixes: 7862b4058b9f ("esp: Add gso handlers for esp4 and esp6")

and applied it to ipsec-next, thanks!

> 
> At a minimum you should work to check that you are CC:'ing the person
> who added the code you are fixing.  You can use "git blame" for this.
> 
> Also, Steffen, you need to add the new IPSEC offload files to the
> MAINTAINERS entry for iPSEC.

Yes, will do a patch.