public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Myungho Jung <mhjungk@gmail•com>
To: Greg Rose <gvrose8192@gmail•com>
Cc: edumazet@google•com, netdev@vger•kernel.org
Subject: Re: [PATCH] p54: Prevent from dereferencing null pointer when releasing SKB
Date: Thu, 20 Apr 2017 16:23:49 -0700	[thread overview]
Message-ID: <20170420232349.GA25174@fqdn.specialj.com> (raw)
In-Reply-To: <1492729423.17866.6.camel@gmail.com>

On Thu, Apr 20, 2017 at 04:03:43PM -0700, Greg Rose wrote:
> On Thu, 2017-04-20 at 11:25 -0700, Myungho Jung wrote:
> > Added NULL check to make __dev_kfree_skb_irq consistent with kfree
> > family of functions.
> > 
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=195289
> > 
> > Signed-off-by: Myungho Jung <mhjungk@gmail•com>
> 
> Hi,
> 
> I think the patch is fine but I'm confused by the subject.  You mention
> p54 driver but the change is in dev.c.  I know the bugzilla references
> the p54 but that's not where the change is.
> 
> Seems odd to me.
> 
> - Greg
> 
> > ---
> >  net/core/dev.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/net/core/dev.c b/net/core/dev.c
> > index 7869ae3..22be2a6 100644
> > --- a/net/core/dev.c
> > +++ b/net/core/dev.c
> > @@ -2450,6 +2450,9 @@ void __dev_kfree_skb_irq(struct sk_buff *skb, enum skb_free_reason reason)
> >  {
> >  	unsigned long flags;
> >  
> > +	if (unlikely(!skb))
> > +		return;
> > +
> >  	if (likely(atomic_read(&skb->users) == 1)) {
> >  		smp_rmb();
> >  		atomic_set(&skb->users, 0);
> 
> 
> 

Hi Greg,

Thank you for checking my patch. I missed that I moved change from p54
to net/dev. Do I need to resubmit patch v2 to modify subject?

Thanks,
Myungho

next prev parent reply	other threads:[~2017-04-20 23:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-20 18:25 [PATCH] p54: Prevent from dereferencing null pointer when releasing SKB Myungho Jung
2017-04-20 23:03 ` Greg Rose
2017-04-20 23:23   ` Myungho Jung [this message]
2017-04-20 23:25     ` Greg Rose
  -- strict thread matches above, loose matches on Subject: below --
2017-04-10 22:39 Myungho Jung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170420232349.GA25174@fqdn.specialj.com \
    --to=mhjungk@gmail$(echo .)com \
    --cc=edumazet@google$(echo .)com \
    --cc=gvrose8192@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox